Extend interface discovery to allow discovery of multiple service labels #798
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
This changes the Interface Discovery Ruleset and the Discovery itself to allow multiple service labels with individual matching conditions to be defined in a single rule.
Proposed changes
Prior to this the discovery ruleset only allowed a list of service labels that would be discovered if the "Conditions for this rule to apply" would apply. If you would want to discover multiple service labels based on different conditions, you would need multiple rules and with any one additional service label the amount of rules would be increasing exponentially.
This request introduces an additional setting, that extends the service label discovery by allowing multiple sets of service labels with explicit matching conditions (index, alias and description):
