Skip to content

Extend interface discovery to allow discovery of multiple service labels #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lbuhleie
Copy link

General information

This changes the Interface Discovery Ruleset and the Discovery itself to allow multiple service labels with individual matching conditions to be defined in a single rule.

Proposed changes

Prior to this the discovery ruleset only allowed a list of service labels that would be discovered if the "Conditions for this rule to apply" would apply. If you would want to discover multiple service labels based on different conditions, you would need multiple rules and with any one additional service label the amount of rules would be increasing exponentially.

This request introduces an additional setting, that extends the service label discovery by allowing multiple sets of service labels with explicit matching conditions (index, alias and description):
if_discovery

Copy link

github-actions bot commented Feb 26, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@lbuhleie
Copy link
Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@lbuhleie
Copy link
Author

@englertor can you check this again, I do not see if further adapations are needed for the formatting / test checks to run successfully

@englertor
Copy link
Contributor

@lbuhleie: Thanks for your contribution.

We add the label "tracked" as soon as our general criterias for PRs are fulfilled (e.g. passing tests, formatting ...). After that, we replicate it in our internal system to prioritize and assign.

So right now this PR is waiting for capacity from our developers and there is currently nothing left to do from your side.

@lbuhleie
Copy link
Author

@englertor thank you for the explanation, then I'll just wait :)

@englertor englertor added tracked and removed tracked labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants