Skip to content
This repository was archived by the owner on Jun 12, 2023. It is now read-only.

fix: issues after MetaMask update with breaking changes #244

Closed
wants to merge 4 commits into from
Closed

fix: issues after MetaMask update with breaking changes #244

wants to merge 4 commits into from

Conversation

navFooh
Copy link

@navFooh navFooh commented Feb 21, 2023

Fixes the following issues:

Something seems to go wrong with linking the packages when running the demo locally, since I get the following error:

Failed to compile.
./src/containers/MetaMaskConnector/MetaMaskConnector.tsx
Module not found: Can't resolve '@chainsafe/filsnap-adapter' in 'C:\dev\chainsafe\filsnap\packages\example\src\containers\MetaMaskConnector'

However, I've been able to test the RPC changes in my local project and that seems to work fine.
The only problem is that I still get the error about the snap permissions and I'm not sure if we can even test that properly without first deploying the new snap version and installing it in MetaMask.

@CLAassistant
Copy link

CLAassistant commented Feb 21, 2023

CLA assistant check
All committers have signed the CLA.

@navFooh navFooh marked this pull request as draft February 21, 2023 11:27
@navFooh navFooh changed the title Fix issues after MetaMask update with breaking changes fix: issues after MetaMask update with breaking changes Feb 21, 2023
@navFooh
Copy link
Author

navFooh commented Feb 21, 2023

Fixes: #243

@navFooh navFooh marked this pull request as ready for review February 21, 2023 12:18
@BeroBurny
Copy link
Contributor

Thanks for taking the time to contribute to a project, we appreciate any community help.

Most of the PR looks good but it covering breaking changes related to the adapter, unfortunate there is more related to the snap itself, @irubido can you please check in detail?
(even merge and do rest work on top of it)

@irubido
Copy link
Contributor

irubido commented Feb 23, 2023

Hi @navFooh
I appreciate the effort of updating filsnap, adapter changes you made are on the right track, there's just a couple of more things are needed with it, and updating snap itself.
I already started working on the updating filsnap adapter and snap, and PR will be ready soon.
Thanks for your effort

@navFooh
Copy link
Author

navFooh commented Feb 23, 2023

Hi @irubido,
My pleasure! Good to hear that you're working on it.

@BeroBurny
Copy link
Contributor

Unfortunaly we are not going to merge this in favor of #246

Thanks for participating and attempting to contribute to a project. We appreciate your effort 🙏

@BeroBurny BeroBurny closed this Mar 3, 2023
@navFooh
Copy link
Author

navFooh commented Mar 5, 2023

My pleasure! Thank you for maintaining this project 🙏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants