Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppsspp(-dev): Fix manifests, Update test.ps1 to Pester 5 #745

Merged
merged 7 commits into from
Dec 23, 2022
Merged

ppsspp(-dev): Fix manifests, Update test.ps1 to Pester 5 #745

merged 7 commits into from
Dec 23, 2022

Conversation

sitiom
Copy link
Contributor

@sitiom sitiom commented Nov 18, 2022 •
edited
Loading

BREAKING CHANGES

IMPORTANT FOR BUCKET MAINTAINERS

  • Pester 5 is used in this release. To make sure your bucket's CI works properly, please update bin\test.ps1 from Pester 4 to Pester 5.
  • You can use test.ps1 attached in the release files.

Calinou
Calinou approved these changes Nov 18, 2022
View reviewed changes
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Calinou
Copy link
Owner

Calinou commented Nov 18, 2022 •
edited
Loading

There are CI failures due to ppsspp-dev and ppsspp. Would you mind fixing those manifests in this PR so it can be merged with successful CI? Thanks in advance 🙂

@sitiom sitiom changed the title Update test.ps1 to Pester 5 Update test.ps1 to Pester 5, Fix ppsspp(-dev) manifests Nov 18, 2022
@sitiom
Copy link
Contributor Author

sitiom commented Nov 18, 2022

/verify

@sitiom sitiom changed the title Update test.ps1 to Pester 5, Fix ppsspp(-dev) manifests ppsspp(-dev): Fix manifests, Update test.ps1 to Pester 5 Nov 18, 2022
@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

ppsspp-dev

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

ppsspp

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

@sitiom
Copy link
Contributor Author

sitiom commented Nov 18, 2022

@Calinou all good

@sitiom sitiom changed the title ppsspp(-dev): Fix manifests, Update test.ps1 to Pester 5 ppsspp(-dev): Fix manifests, Update test.ps1 to Pester 5 Nov 19, 2022
@sitiom sitiom requested a review from Calinou November 20, 2022 01:43
@sitiom
Copy link
Contributor Author

sitiom commented Dec 22, 2022

@Calinou bump

@sitiom
Copy link
Contributor Author

sitiom commented Dec 22, 2022

Errors due to unrelated files:
image

@Calinou
Copy link
Owner

Calinou commented Dec 22, 2022

Needs a rebase again (sorry, I wasn't at my PC today).

@sitiom
Copy link
Contributor Author

sitiom commented Dec 23, 2022

@Calinou done

Calinou
Calinou approved these changes Dec 23, 2022
View reviewed changes
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Calinou
Calinou reviewed Dec 23, 2022
View reviewed changes
Copy link
Owner

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I accidentally undid some of your changes during conflict resolution. (It's not obvious what "current change" and "incoming change" refer to in GitHub's online conflict resolution dialog…).

@sitiom
Copy link
Contributor Author

sitiom commented Dec 23, 2022

All fixed 🙂

@Calinou Calinou merged commit 598c3fa into Calinou:master Dec 23, 2022
@sitiom sitiom deleted the patch-1 branch December 23, 2022 15:19
@Calinou Calinou added the bug Something isn't working label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
bug Something isn't working review-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sitiom @Calinou