Update Grafana/Prometheus Chart #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trispera
commented
Mar 7, 2024
trispera
commented
- Remove nginx server in front of Prometheus
- New functions to generate and store a random password (props to Document solution to problem of random passwords change on upgrade (from helm/charts) helm/helm-www#1259 (comment))
- Password won't change if a Chart upgrade is made.
- Remove nginx server in front of Prometheus - New functions to generate and store a random password - Password won't change if a Chart upgrade is made.
trispera
changed the title
trispera
changed the title
lvarin
reviewed
Mar 11, 2024
| data: | ||
| {{- range $key, $val := .Values.grafana.secret }} | ||
| "{{ $key }}": "{{ tpl $val $ | b64enc }}" |
There was a problem hiding this comment.
Why use b64enc and data, and not stringdata?
lvarin
approved these changes
Mar 11, 2024
| data: | ||
| {{- range $key, $val := .Values.grafana.secret }} | ||
| "{{ $key }}": "{{ tpl $val $ | b64enc }}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.