Rename Region views
#347
Merged
Rename Region views
#347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Credits to @acl-cqc for the suggestions! |
ss2165
reviewed
Aug 3, 2023
src/hugr/hierarchy.rs
Outdated
| @@ -1,14 +1,16 @@ | |||
| //! Region-level views of a HUGR. | |||
There was a problem hiding this comment.
maybe the file/module should be called views.rs?
There was a problem hiding this comment.
I would like that, but there is already the view.rs file in the same folder that contains HugrView etc.
I could make a views folder with
views/hugr.rsviews/hierarchy.rs
in it?
There was a problem hiding this comment.
or just go with hierarchical_views
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 8, 2023
* Add simpler variant of Resource.add_op_custom_sig(). * Use Resource.add_op_custom_sig_simple() where possible. * Fix typo in spec. * Define SignatureError::InvalidTypeArgs. * Define HashableType::OpError. * Define TypeArgError::InvalidValue. * Implement Arithmetic Resource. * Use constants rather than functions for type IDs. * Move arithmetic.rs to arithmetic/mod.rs. * Add method to create a resource with requirements. * Add method to create a ResourceSet from some resources. * Refactor into separate modules. * Rename `Region` views (#347) * Rename `Region` views * Rename hierarchy -> hierarchical_views * separate TypeParam hierarchy (#364) * separate TypeParam hierarchy Closes #359 * address review comments * move the contents of typecheck.rs to values.rs * more review comments * cherry-pick CustomTypeArg from #335 * define TypeTag::contains and use in arg check * Post-merge fixup. * Remove INT_PARAM constant. * Use constants for resource IDs, and settle on lowercase. * Remove HashableType::OpError and just use String (for now). * Make SignatureError::InvalidTypeArgs a constant. * Use utility function collect_array(). --------- Co-authored-by: Luca Mondada <[email protected]> Co-authored-by: Seyon Sivarajah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose the following renaming
FlatRegionView->SiblingGraphRegionView->DescendantsGraphRegion->HierarchyViewI've reserved the term
Viewfor the trait rather than thestructs as that is closer to our use of the word elsewhere. Happy to discuss other opinions.In addition to being more descriptive, this will also allow us to make the complementarity with #336 more obvious.