Query all controllers for backups #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There currently is a problem with ctl-0, which is where we always
fetched backups from.
This extends the fetch script to look in the directories of other
controllers too.
Additionally, it fixes a KeyError when nothing is returned from
the query. It now checks for the presence of the key, rather than
size.
```python
File "/app/openstack_billing_db/fetch.py", line 67, in download_latest_dump_from_s3
if len(dumps["Contents"]) == 0:
~~~~~^^^^^^^^^^^^
KeyError: 'Contents'
```
naved001
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There currently is a problem with ctl-0, which is where we always fetched backups from.
This extends the fetch script to look in the directories of other controllers too.
Additionally, it fixes a KeyError when nothing is returned from the query. It now checks for the presence of the key, rather than size.