Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for successful conda builds #650

Merged
merged 6 commits into from
Sep 1, 2023

Conversation

tony-p
Copy link
Contributor

@tony-p tony-p commented Sep 1, 2023

Made changes to the cmake files to also find ZeroMQ when using the conda dependency while still being able to find it for the traditional builds.

Add extra include to minitrace.cpp so that standard int definition macros are definitely available in a linux conda environment

Add workflow for conda builds

Solves: #640

Prepares for: #644

@tony-p tony-p mentioned this pull request Sep 1, 2023
@tony-p
Copy link
Contributor Author

tony-p commented Sep 1, 2023

2 tests are failing on the Windows build, 1 is the same master (see #647)

and 1 other SequenceTripleActionTest - TripleAction

@tony-p
Copy link
Contributor Author

tony-p commented Sep 1, 2023

Both failures seem to be timing related

[ RUN      ] SequenceTripleActionTest.TripleAction
D:\a\BehaviorTree.CPP\BehaviorTree.CPP\build-env\BehaviorTree.CPP\tests\gtest_sequence.cpp(274): error: Value of: system_clock::now() < timeout
  Actual: false
Expected: true
[  FAILED  ] SequenceTripleActionTest.TripleAction (655 ms)

Locally this test passes for me on windows

@tony-p tony-p changed the title WIP: Add support for successful conda builds Add support for successful conda builds Sep 1, 2023
@facontidavide facontidavide merged commit a086685 into BehaviorTree:master Sep 1, 2023
@facontidavide
Copy link
Collaborator

thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants