Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Trade] Add trade cooldown bypass policy #552

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Trade] Add trade cooldown bypass policy #552

wants to merge 2 commits into from

Conversation

flaree
Copy link
Member

@flaree flaree commented Feb 19, 2025

Description of the changes

  • Add cooldown bypass policy
  • Handle cooldown bypassing in trade
  • Add policy to info command (admin/player)

Were the changes in this PR tested?

Yes

@flaree flaree requested a review from laggron42 February 19, 2025 14:34
@flaree flaree force-pushed the feat/TradeAcceptanceBypass branch from 84fe1c4 to 4ae9c56 Compare February 19, 2025 14:37
@flaree flaree force-pushed the feat/TradeAcceptanceBypass branch from 4ae9c56 to 6fffc1e Compare February 19, 2025 14:39
TridentInsurgence
TridentInsurgence reviewed Feb 19, 2025
View reviewed changes
Copy link

@TridentInsurgence TridentInsurgence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of "Bypass acceptance cooldown" maybe call it "No acceptance cooldown" or "Remove acceptance cooldown"

@flaree
Copy link
Member Author

flaree commented Feb 19, 2025

I prefer bypass as that's what it is, you're bypassing it. It's on by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TridentInsurgence TridentInsurgence TridentInsurgence left review comments

@laggron42 laggron42 Awaiting requested review from laggron42

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flaree @TridentInsurgence