Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.1 Deployment #501

Merged
merged 17 commits into from
Mar 28, 2025
Merged

8.1 Deployment #501

merged 17 commits into from
Mar 28, 2025

Conversation

@adecler adecler added the type:feature New capability or enhancement label Mar 18, 2025
adecler and others added 6 commits March 19, 2025 16:01
Fixes checks by adding [] as split chars
Instead of explicitly checking some specific folder and specific indices simply loop backwards from the filename to the create folder and check if one of the paths is a match.

Avoid the copy pasting of regex, and constant index out of bounds exceptions being thrown.
…ncompleteComplianceChecks

Tweaks to compliance checks to handle edge cases
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with the changes in this PR. Code already in use on the Bot, and tests functioning as expected.

Some additional pre-exiting issues found, and PRs raised for them to be incorporated after the 8.1 release:
#510
#512

#512 is relating to the current compliance failure on this PR. Believe fine to dispensate this the check for this PR, as a fix is on the way, and problem kown. Happy to approve.

Copy link

bhombot-ci bot commented Mar 28, 2025

FAO: @adecler @pawelbaran @IsakNaslundBh
@IsakNaslundBh is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is project-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 39153284209

@IsakNaslundBh
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 39153284209

Copy link

bhombot-ci bot commented Mar 28, 2025

@IsakNaslundBh I have now provided a passing check on reference 39153284209 as requested.

@al-fisher al-fisher merged commit 694af96 into main Mar 28, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants