Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #11978

Merged
merged 5 commits into from
Feb 13, 2025
Merged

feat: Sync from noir #11978

merged 5 commits into from
Feb 13, 2025

Conversation

AztecBot
Copy link
Collaborator

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: deprecate keccak256 (noir-lang/noir#7361)
feat: FunctionDefinition::as_typed_expr (noir-lang/noir#7358)
feat(performance): Check sub operations against induction variables (noir-lang/noir#7356)
chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357)
feat(cli): Add --target-dir option (noir-lang/noir#7350)
fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190)
feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344)
chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351)
fix: incorrect secondary file in LSP errors (noir-lang/noir#7347)
chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341)
fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345)
chore: remove some unused types and functions in the AST (noir-lang/noir#7339)
chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337)
chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342)
chore: redo typo PR by osrm (noir-lang/noir#7238)
chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914)
fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327)
fix: perform SSA constraints check on final SSA (noir-lang/noir#7334)
chore: remove misleading output from nargo check (noir-lang/noir#7329)
chore: fix warnings (noir-lang/noir#7330)
chore: normalize path displayed by nargo new (noir-lang/noir#7328)
chore: split acirgen into multiple modules (noir-lang/noir#7310)
chore: remove unnecessary constants (noir-lang/noir#7326)
END_COMMIT_OVERRIDE

AztecBot and others added 4 commits February 13, 2025 12:20
feat: `FunctionDefinition::as_typed_expr` (noir-lang/noir#7358)
feat(performance): Check sub operations against induction variables (noir-lang/noir#7356)
chore: avoid doing all brillig integer arithmetic on u128s (noir-lang/noir#7357)
feat(cli): Add `--target-dir` option (noir-lang/noir#7350)
fix(ssa): Make the lookback feature opt-in (noir-lang/noir#7190)
feat(performance): Use unchecked ops based upon known induction variables (noir-lang/noir#7344)
chore: mark sha256 as deprecated from the stdlib (noir-lang/noir#7351)
fix: incorrect secondary file in LSP errors (noir-lang/noir#7347)
chore: Basic test for MSM in Noir to catch performance improvements and regressions (noir-lang/noir#7341)
fix(cli): Only lock the packages selected in the workspace (noir-lang/noir#7345)
chore: remove some unused types and functions in the AST (noir-lang/noir#7339)
chore: remove foreign calls array from Brillig VM constructor (noir-lang/noir#7337)
chore(ci): Add Vecs and vecs to cspell (noir-lang/noir#7342)
chore: redo typo PR by osrm (noir-lang/noir#7238)
chore: Release Noir(1.0.0-beta.2) (noir-lang/noir#6914)
fix: lock git dependencies folder when resolving workspace (noir-lang/noir#7327)
fix: perform SSA constraints check on final SSA (noir-lang/noir#7334)
chore: remove misleading output from `nargo check` (noir-lang/noir#7329)
chore: fix warnings (noir-lang/noir#7330)
chore: normalize path displayed by `nargo new` (noir-lang/noir#7328)
chore: split acirgen into multiple modules (noir-lang/noir#7310)
chore: remove unnecessary constants (noir-lang/noir#7326)
@TomAFrench TomAFrench enabled auto-merge (squash) February 13, 2025 13:18
Copy link
Contributor

Changes to public function bytecode sizes

Generated at commit: 4ed49951921315b0530a3dc15d7f3b15b80b7063, compared to commit: 95b581de29df183c7ee443c990fef11a3f9a301e

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
Parent::public_dispatch -18 ✅ -0.24%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -18 ✅ -0.27%
NFT::public_dispatch -82 ✅ -0.32%
Token::public_dispatch -105 ✅ -0.33%
Token::_finalize_transfer_to_private_unsafe -18 ✅ -0.35%
Token::finalize_transfer_to_private -18 ✅ -0.35%
Token::_finalize_mint_to_private_unsafe -18 ✅ -0.37%
Token::finalize_mint_to_private -18 ✅ -0.37%
NFT::_finalize_transfer_to_private_unsafe -18 ✅ -0.39%
NFT::finalize_transfer_to_private -18 ✅ -0.39%
AvmTest::public_dispatch -254 ✅ -0.43%
AppSubscription::public_dispatch -23 ✅ -0.49%
Parent::public_nested_static_call -18 ✅ -0.51%
Token::transfer_in_public -23 ✅ -0.53%
AvmTest::external_call_to_divide_by_zero_recovers -18 ✅ -0.64%
AppSubscription::constructor -23 ✅ -0.64%
AvmTest::emit_public_log -18 ✅ -0.75%
AvmGadgetsTest::sha256_hash_2048 -156 ✅ -0.84%
Token::constructor -41 ✅ -0.85%
AvmGadgetsTest::public_dispatch -420 ✅ -0.87%
NFT::constructor -41 ✅ -0.90%
AvmTest::bulk_testing -218 ✅ -0.98%
DocsExample::public_dispatch -64 ✅ -1.30%
Uniswap::public_dispatch -359 ✅ -1.48%
Test::public_dispatch -318 ✅ -1.72%
TokenBridge::public_dispatch -372 ✅ -1.78%
AvmGadgetsTest::sha256_hash_511 -156 ✅ -1.94%
AvmGadgetsTest::sha256_hash_512 -156 ✅ -1.97%
Uniswap::swap_public -341 ✅ -2.26%
AvmGadgetsTest::sha256_hash_100 -112 ✅ -2.30%
TokenBridge::exit_to_l1_public -184 ✅ -2.30%
AvmGadgetsTest::sha256_hash_90 -112 ✅ -2.33%
AvmGadgetsTest::sha256_hash_80 -112 ✅ -2.36%
AvmGadgetsTest::sha256_hash_70 -112 ✅ -2.40%
AvmGadgetsTest::sha256_hash_255 -156 ✅ -2.50%
TokenBridge::claim_public -318 ✅ -2.50%
AvmGadgetsTest::sha256_hash_256 -156 ✅ -2.54%
AvmTest::u128_addition_overflow -36 ✅ -2.76%
AvmGadgetsTest::sha256_hash_60 -112 ✅ -2.93%
Test::consume_mint_to_public_message -318 ✅ -2.93%
AvmGadgetsTest::sha256_hash_50 -112 ✅ -3.01%
AvmGadgetsTest::sha256_hash_40 -112 ✅ -3.09%
AvmGadgetsTest::sha256_hash_30 -112 ✅ -3.14%
AvmGadgetsTest::sha256_hash_20 -112 ✅ -3.22%
AvmGadgetsTest::sha256_hash_10 -112 ✅ -3.27%
Test::consume_message_from_arbitrary_sender_public -282 ✅ -3.62%
AvmGadgetsTest::keccak_hash -106 ✅ -4.66%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
Parent::public_dispatch 7,619 (-18) -0.24%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,599 (-18) -0.27%
NFT::public_dispatch 25,385 (-82) -0.32%
Token::public_dispatch 32,177 (-105) -0.33%
Token::_finalize_transfer_to_private_unsafe 5,160 (-18) -0.35%
Token::finalize_transfer_to_private 5,113 (-18) -0.35%
Token::_finalize_mint_to_private_unsafe 4,834 (-18) -0.37%
Token::finalize_mint_to_private 4,787 (-18) -0.37%
NFT::_finalize_transfer_to_private_unsafe 4,635 (-18) -0.39%
NFT::finalize_transfer_to_private 4,588 (-18) -0.39%
AvmTest::public_dispatch 58,329 (-254) -0.43%
AppSubscription::public_dispatch 4,708 (-23) -0.49%
Parent::public_nested_static_call 3,496 (-18) -0.51%
Token::transfer_in_public 4,328 (-23) -0.53%
AvmTest::external_call_to_divide_by_zero_recovers 2,810 (-18) -0.64%
AppSubscription::constructor 3,564 (-23) -0.64%
AvmTest::emit_public_log 2,372 (-18) -0.75%
AvmGadgetsTest::sha256_hash_2048 18,517 (-156) -0.84%
Token::constructor 4,806 (-41) -0.85%
AvmGadgetsTest::public_dispatch 47,664 (-420) -0.87%
NFT::constructor 4,497 (-41) -0.90%
AvmTest::bulk_testing 21,920 (-218) -0.98%
DocsExample::public_dispatch 4,861 (-64) -1.30%
Uniswap::public_dispatch 23,915 (-359) -1.48%
Test::public_dispatch 18,146 (-318) -1.72%
TokenBridge::public_dispatch 20,535 (-372) -1.78%
AvmGadgetsTest::sha256_hash_511 7,886 (-156) -1.94%
AvmGadgetsTest::sha256_hash_512 7,760 (-156) -1.97%
Uniswap::swap_public 14,743 (-341) -2.26%
AvmGadgetsTest::sha256_hash_100 4,767 (-112) -2.30%
TokenBridge::exit_to_l1_public 7,802 (-184) -2.30%
AvmGadgetsTest::sha256_hash_90 4,697 (-112) -2.33%
AvmGadgetsTest::sha256_hash_80 4,627 (-112) -2.36%
AvmGadgetsTest::sha256_hash_70 4,557 (-112) -2.40%
AvmGadgetsTest::sha256_hash_255 6,082 (-156) -2.50%
TokenBridge::claim_public 12,393 (-318) -2.50%
AvmGadgetsTest::sha256_hash_256 5,974 (-156) -2.54%
AvmTest::u128_addition_overflow 1,266 (-36) -2.76%
AvmGadgetsTest::sha256_hash_60 3,717 (-112) -2.93%
Test::consume_mint_to_public_message 10,534 (-318) -2.93%
AvmGadgetsTest::sha256_hash_50 3,604 (-112) -3.01%
AvmGadgetsTest::sha256_hash_40 3,510 (-112) -3.09%
AvmGadgetsTest::sha256_hash_30 3,459 (-112) -3.14%
AvmGadgetsTest::sha256_hash_20 3,370 (-112) -3.22%
AvmGadgetsTest::sha256_hash_10 3,317 (-112) -3.27%
Test::consume_message_from_arbitrary_sender_public 7,498 (-282) -3.62%
AvmGadgetsTest::keccak_hash 2,169 (-106) -4.66%

@TomAFrench TomAFrench merged commit 5efdd57 into master Feb 13, 2025
52 checks passed
@TomAFrench TomAFrench deleted the sync-noir branch February 13, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants