When some instances are hidden there is a difference between the Scene #1186
Conversation
…e Delegate instance Id and the Maya instance Id. Store a mapping buffter from the Scene Delegate Id to the Maya Id so we can correctly draw selection highlights.
| // Assign with the index to the active selection highlight color. | ||
| if (const auto state = drawScene.GetActiveSelectionState(id)) { | ||
| for (const auto& indexArray : state->instanceIndices) { | ||
| for (const auto index : indexArray) { | ||
| colorIndices[index] = 1; | ||
| if (index < delegateToVp2Map.size()) { | ||
| int vp2InstanceIndex = delegateToVp2Map[index]; |
There was a problem hiding this comment.
We need to convert the scene delegate instance id into the Maya instance id to know which instance to draw.
| } | ||
| } else { | ||
| instancerWithNoInstances = true; |
There was a problem hiding this comment.
This is also necessary to not draw something at the origin when only hidden instances are selected.
huidong-chen
added
vp2renderdelegate
|
I guess we also have to mirror the change to basisCurves? |
| // vector. | ||
| VtIntArray delegateToVp2Map = static_cast<HdVP2Instancer*>(instancer) | ||
| ->ComputeInstanceIdToVp2InstanceIdArray(id); | ||
|
|
There was a problem hiding this comment.
It is very similar to the mesh version. The only difference is I don't have to track is any instances are visible here. In the basis curve case I know some instances are visible because of the earlier check, and we re-use a single render item to draw the dormant curves as well as the lead & active items. The only thing we have to get right is which items do we change the color of, and that is what the new changes do.
williamkrick
assigned williamkrick and ecp-maya-devops-adsk and unassigned ecp-maya-devops-adsk and williamkrick
williamkrick
added
the
ready-for-merge
kxl-adsk
removed
the
ready-for-merge
|
Logged PixarAnimationStudios/OpenUSD#1461. Will revisit once we have an answer. |
williamkrick
deleted the
krickw/MAYA-109886/scene_delegate_to_maya_instance_id_mapping
branch
Delegate instance Id and the Maya instance Id. Store a mapping buffer from the Scene Delegate Id to the Maya Id so we can correctly draw selection highlights.