feat: For the performance test shell script, add a prefix that can reuse the created topic #2401
Conversation
Captain-Slacker-OwO
requested review from
superhx,
SCNieh,
Chillax-0v0 and
Gezi-lzq
as code owners
Captain-Slacker-OwO
changed the title
Captain-Slacker-OwO
changed the title
Captain-Slacker-OwO
changed the title
| tasks.withType(JavaCompile) { | ||
| options.compilerArgs += ["-Xlint:-this-escape"] | ||
| } |
There was a problem hiding this comment.
Disabling -Xlint:this-escape globally is not recommended, as it suppresses critical warnings about unsafe object initialization (e.g., this escaping constructors before full initialization). This could hide concurrency risks.
Instead, consider using @SuppressWarnings("this-escape") locally if unavoidable, but prioritize fixing the root cause for safer code.
| // Modified producer start logic | ||
| Function<String, List<byte[]>> payloads = payloads(config, topics); | ||
| producerService.start(payloads, config.sendRate); | ||
| if (config.catchupTopicPrefix != null) { | ||
| LOGGER.info("Starting catchup test with existing topics"); | ||
| producerService.start(payloads, config.sendRate); | ||
| } else { | ||
| LOGGER.info("Starting normal test with new topics"); | ||
| producerService.start(payloads, config.sendRate); | ||
| } |
There was a problem hiding this comment.
What is the purpose of this code modification?
| Function<String, List<byte[]>> payloads = payloads(config, topics); | ||
| producerService.start(payloads, config.sendRate); | ||
| if (config.catchupTopicPrefix != null) { |
There was a problem hiding this comment.
[nitpick] Consider checking if config.catchupTopicPrefix is not only non-null but also non-empty, to maintain consistency with the validation logic in PerfConfig.java.
| if (config.catchupTopicPrefix != null) { | |
| if (!Strings.isNullOrEmpty(config.catchupTopicPrefix)) { |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
This pull request attempts to resolve #2373 .