fix(pack/rust): Ensure that taplo is only initialized once.

[sjcobb2022]

Closes #90

Ensure that taplo is only initialized once.

Just added it to astronvim.lsp.skip_setup.

[sjcobb2022]

Sorry for all the commits, i forgot to clean my branch.

[mehalter]

@sjcobb2022 I went and fixed the git history on your branch. One thing I should point out is that this is actually not a real "fix". Taplo here is not being initialized twice as a language server. It is having the language server initialize and it is also having the null-ls sources initialize through mason-null-ls. This is disabling the language server and just letting null-ls set it up for linting. This is not the ideal behavior as we probably want the reverse of this. Disabling the null-ls and only using the LSP. I'm going to discuss with the mason-null-ls dev to see the best way to move forward with this.

EDIT: just to clarify, there are no real requests for changes here, just blocking the commit for now until we clear this up

[sjcobb2022]

@sjcobb2022 I went and fixed the git history on your branch. One thing I should point out is that this is actually not a real "fix". Taplo here is not being initialized twice as a language server. It is having the language server initialize and it is also having the null-ls sources initialize through mason-null-ls. This is disabling the language server and just letting null-ls set it up for linting. This is not the ideal behavior as we probably want the reverse of this. Disabling the null-ls and only using the LSP. I'm going to discuss with the mason-null-ls dev to see the best way to move forward with this.

EDIT: just to clarify, there are no real requests for changes here, just blocking the commit for now until we clear this up

Alright alright, that sounds good. Feel free to close the pull if you want to move in another direction!

[mehalter]

Alright alright, that sounds good. Feel free to close the pull if you want to move in another direction!

Ok thanks! I'll keep you updated :D I'm hoping we can get setup_handlers moved to the setup call of mason-null-ls and mason-nvim-dap so that it's easy to override them to not set up different sources easily

[mehalter]

Good news @sjcobb2022 ! This PR on mason-null-ls will enable us to do what we want ❤️

jay-babu/mason-null-ls.nvim#55

Once this gets merged in I can update this to use it and we can ship this :D

[sjcobb2022]

Good news @sjcobb2022 ! This PR on mason-null-ls will enable us to do what we want ❤️

jay-babu/mason-null-ls.nvim#55

Once this gets merged in I can update this to use it and we can ship this :D

Awesome! That sounds great!

Should I close the pull or are we going to just keep this up and edit it.

[mehalter]

@sjcobb2022 actually, I had a different idea of how we could structure these packs in a more semantically meaningful way, check out #94 . This will make it easier for us to do fixes like this and fix it in all the places where toml language is used like rust + julia. So I am going to go ahead and close this and we can make a new PR that just fixes the toml language pack when that PR comes in. Thanks for catching this, opening an issue, and investigating!!