Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vscode-icons): add more and update lspkind icons #851

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

manuuurino
Copy link
Contributor

📑 Description

Ive noticed that the lspkind icons look kinda outdated? So thats why i would like to update them, since i saw the config from kabin.

ℹ Additional Information

Snippet from kabin's config: https://github.com/kabinspace/AstroNvim_user/blob/c114034e98a5291c1d4369f74143f21ba2e28079/lua/plugins/lspkind.lua#L7-L31

Copy link

github-actions bot commented Apr 9, 2024

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Proper usage of opts table rather than setting things up with the config function.

@Uzaaft Uzaaft merged commit dedf12e into AstroNvim:main Apr 9, 2024
13 checks passed
This was referenced Apr 8, 2024
@mehalter
Copy link
Member

This was incorrect. I will revert.

@mehalter
Copy link
Member

All of the icons that this got changed to are the default codicons when setting the preset: https://github.com/onsails/lspkind.nvim/blob/master/lua/lspkind/init.lua#L34-L60

We add the kinds that are missing from that list. Which are up to date and correct from codicons

@mehalter
Copy link
Member

Reverted with df5475b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants