Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): Move eslint-lsp to the proper plugin, and add autocmd to format on save #683

Merged
merged 4 commits into from
Dec 15, 2023

Update lua/astrocommunity/pack/typescript/init.lua

a92bdaa
Select commit
Loading
Failed to load commit list.
Merged

feat(typescript): Move eslint-lsp to the proper plugin, and add autocmd to format on save #683

Update lua/astrocommunity/pack/typescript/init.lua
a92bdaa
Select commit
Loading
Failed to load commit list.
Task list completed / task-list-completed succeeded Dec 15, 2023 in 0s

3 / 3 tasks completed

All tasks have been completed

Details

Required Tasks

Task Status
If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin Incomplete
If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error Incomplete
Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above Completed
README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url) Completed
Proper usage of opts table rather than setting things up with the config function. Completed
We only need to create auto commands for :EslintFixAll for buffers that have eslint attached. Incomplete
Makes it easier to disable and also init functions do not stack so that's a bad insertion point Incomplete
fixes bug eslint-lsp should be eslint since that's the name of the language server Incomplete