Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(copilot-lua-cmp): add blink.cmp support #1350

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

azdanov
Copy link
Contributor

@azdanov azdanov commented Feb 1, 2025

πŸ“‘ Description

This should hopefully add similar copilot support to blink as it was for cmp. Not sure if it's 1 to 1, since I'm not familiar with either of them πŸ™ˆ

β„Ή Additional Information

I've checked https://cmp.saghen.dev/configuration/keymap.html#example and copied Tab from main community pack.

Copy link

github-actions bot commented Feb 1, 2025

Review Checklist

Does this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist:

Proper conventional commit scoping:

  • If you are adding a new plugin, the scope would be the name of the category it is being added into. ex. feat(utility): added noice.nvim plugin

  • If you are modifying a pre-existing plugin or pack, the scope would be the name of the plugin folder. ex. fix(noice-nvim): fix LSP handler error

  • Pull request title has the appropriate conventional commit type and scope where the scope is the name of the pre-existing directory in the project as described above

  • README is properly formatted and uses fenced in links with <url> unless they are inside a [title](url)

  • Entry returns a single plugin spec with the new plugin as the only top level spec (not applicable for recipes or packs).

  • Proper usage of opts table rather than setting things up with the config function.

  • Proper usage of specs table for all specs that are not dependencies of a given plugin (not applicable for recipes or packs).

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the README? I'll merge this in after

@mehalter
Copy link
Member

mehalter commented Feb 4, 2025

@azdanov you should revert the lowercase stuff. They should be uppercase.We should normalize all mappings on official keycodes.

Copy link
Member

@mehalter mehalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mehalter mehalter merged commit d4df73c into AstroNvim:main Feb 4, 2025
16 checks passed
@azdanov azdanov deleted the patch-9 branch February 4, 2025 18:28
@jay-babu
Copy link
Contributor

Is it better to use this or the community sources from https://cmp.saghen.dev/configuration/sources#community-sources for copilot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants