-
-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(codesnap-nvim): support for windows users #1123
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
This looks good to me but i think @Uzaaft was looking into an upstream change |
|
What? |
I’m just going to upstream some changes to add a default location to save images. That shouldn’t affect this :) |
@Std-Enigma can you add a note into the readme to document this behaviour |
This commit also adds extra information about windows support and versioning
2f8dbe4
to
9100cce
Compare
Lgtm |
📑 Description
ℹ Additional Information
This plugin at least on the latest version doesn't support windows by any means but the "0.0.x" version does however but it's not so performant and works kinda differently
This PR make sures that windows users get the latest working version that supports their OS