Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Enable PostreSQL extension pg_trgm #1984

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

oskogstad
Copy link
Collaborator

Description

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

Copy link
Contributor

coderabbitai bot commented Feb 28, 2025

📝 Walkthrough

Walkthrough

This update modifies the PostgreSQL deployment configuration within a Bicep file. A new resource, enable_extensions, is introduced to enable the PG_TRGM extension on the PostgreSQL server with a user-override source. Additionally, the existing track_io_timing resource is updated to depend on the enable_extensions resource, ensuring that the extension configuration is applied before the performance configuration.

Changes

File Change Summary
.azure/.../create.bicep Added new resource enable_extensions (type: Microsoft.DBforPostgreSQL/flexibleServers/configurations@2024-08-01) to enable the PG_TRGM extension, and updated track_io_timing to depend on enable_extensions.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@oskogstad oskogstad marked this pull request as ready for review February 28, 2025 12:22
@oskogstad oskogstad requested review from a team as code owners February 28, 2025 12:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.azure/modules/postgreSql/create.bicep (1)

144-151: Enable PostgreSQL Extension Resource Configuration

The new resource is correctly defined to enable the PG_TRGM extension. The use of parent: postgres, the properties set to value: 'PG_TRGM', and the source set to user-override are all consistent with the intended behavior.

**
Consider parameterizing the extension name or resource name (currently hardcoded as 'azure.extensions') if there is a potential need to support additional or different extensions in the future.

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7a506b3 and cf6d2b8.

📒 Files selected for processing (1)
  • .azure/modules/postgreSql/create.bicep (1 hunks)
🔇 Additional comments (1)
.azure/modules/postgreSql/create.bicep (1)

153-161: Ensure Proper Dependency Ordering for Track IO Timing

Adding dependsOn: [enable_extensions] to the track_io_timing resource is a good move. This dependency ensures that the extension enabling is applied before the performance configuration is set, which helps maintain the correct deployment order and configuration consistency.

**

@elsand elsand merged commit 4dce375 into main Feb 28, 2025
17 checks passed
@elsand elsand deleted the feat/enable-postgres-extensions-pg_trgm branch February 28, 2025 12:35
oskogstad pushed a commit that referenced this pull request Feb 28, 2025
🤖 I have created a release *beep* *boop*
---


##
[1.57.0](v1.56.1...v1.57.0)
(2025-02-28)


### Features

* Add reverse indexes on Localizations and SearchTags
([#1971](#1971))
([7a506b3](7a506b3))
* **ci:** Enable PostreSQL extension pg_trgm
([#1984](#1984))
([4dce375](4dce375))


### Miscellaneous Chores

* **sdk:** Add doc
([#1975](#1975))
([37c9130](37c9130))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants