-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): Enable PostreSQL extension pg_trgm #1984
Conversation
📝 WalkthroughWalkthroughThis update modifies the PostgreSQL deployment configuration within a Bicep file. A new resource, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.azure/modules/postgreSql/create.bicep (1)
144-151
: Enable PostgreSQL Extension Resource ConfigurationThe new resource is correctly defined to enable the
PG_TRGM
extension. The use ofparent: postgres
, the properties set tovalue: 'PG_TRGM'
, and the source set touser-override
are all consistent with the intended behavior.**
Consider parameterizing the extension name or resource name (currently hardcoded as'azure.extensions'
) if there is a potential need to support additional or different extensions in the future.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.azure/modules/postgreSql/create.bicep
(1 hunks)
🔇 Additional comments (1)
.azure/modules/postgreSql/create.bicep (1)
153-161
: Ensure Proper Dependency Ordering for Track IO TimingAdding
dependsOn: [enable_extensions]
to thetrack_io_timing
resource is a good move. This dependency ensures that the extension enabling is applied before the performance configuration is set, which helps maintain the correct deployment order and configuration consistency.**
🤖 I have created a release *beep* *boop* --- ## [1.57.0](v1.56.1...v1.57.0) (2025-02-28) ### Features * Add reverse indexes on Localizations and SearchTags ([#1971](#1971)) ([7a506b3](7a506b3)) * **ci:** Enable PostreSQL extension pg_trgm ([#1984](#1984)) ([4dce375](4dce375)) ### Miscellaneous Chores * **sdk:** Add doc ([#1975](#1975)) ([37c9130](37c9130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Description
Related Issue(s)
Verification
Documentation
docs
-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)