-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add updated deploy-process #1981
Conversation
📝 WalkthroughWalkthroughThis pull request updates the deployment documentation and CI/CD workflows to incorporate a new environment named YT01. The README has been modified to include YT01 in the deployment process instructions, and the input options in the associated workflow configuration files have been updated to allow selection of the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
339-346
: Clarify Environment Terminology
The updated deployment step now includes YT01 alongside staging. To improve clarity, consider adding a brief note explaining that YT01 represents the performance environment (or its specific role) so that readers can clearly distinguish between the environments.🧰 Tools
🪛 LanguageTool
[uncategorized] ~344-~344: Possible missing comma found.
Context: ...ment is tagged with the new<version>
without<git-sha>
- The new version is buil...(AI_HYDRA_LEO_MISSING_COMMA)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
docs/deploy-process.png
is excluded by!**/*.png
📒 Files selected for processing (1)
README.md
(3 hunks)
🔇 Additional comments (2)
README.md (2)
374-374
: Updated Workflow Input Options for Applications
The input options for thedispatch-apps.yml
workflow now correctly includeyt01
along withtest
,staging
, andprod
. This update aligns with the PR objectives and improves consistency across environments.
388-388
: Updated Workflow Input Options for Infrastructure
The environment selection for thedispatch-infrastructure.yml
workflow now reflects the addition ofyt01
, ensuring consistent deployment options.
Description
Related Issue(s)
Verification
Documentation
docs
-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)