test

Altinn · Feb 26, 2025 · d7e5b1d · d7e5b1d
1 parent e3f12d5
commit d7e5b1d
Show file tree

Hide file tree

Showing 4 changed files with 22 additions and 2 deletions.
diff --git a/.github/workflows/workflow-build-and-test.yml b/.github/workflows/workflow-build-and-test.yml
@@ -5,6 +5,20 @@ on:
   workflow_call:
 
 jobs:
+  check-for-changes:
+    name: Check for changes
+    uses: ./.github/workflows/workflow-check-for-changes.yml
+
+  check-refitter-swagger-sync:
+    if: ${{ needs.check-for-changes.outputs.hasSwaggerSchemaChanges == 'true' && needs.check-for-changes.outputs.hasWebApiClientRefitterInterfaceChanges != 'true' }}
+    runs-on: ubuntu-latest
+    name: Check refitter swagger sync
+    continue-on-error: true
+    steps:
+      - name: Print message
+        run: |
+          echo "::error:: OpenAPI spec has changed, but the WebAPI SDK Refitter interface has not, forgot to rebuild WebAPI?" && exit 1
+
   build-and-test:
     runs-on: ubuntu-latest
     steps:

diff --git a/.github/workflows/workflow-check-for-changes.yml b/.github/workflows/workflow-check-for-changes.yml
@@ -23,6 +23,9 @@ on:
       hasWebApiClientChanges:
         description: "WebApiClient related files changed"
         value: ${{ jobs.check-for-changes.outputs.hasWebApiClientChanges }}
+      hasWebApiClientRefitterInterfaceChanges:
+        description: "Refitter interface changed"
+        value: ${{ jobs.check-for-changes.outputs.hasWebApiClientRefitterInterfaceChanges }}
       hasTestChanges:
         description: "Test related files changed"
         value: ${{ jobs.check-for-changes.outputs.hasTestChanges }}
@@ -51,6 +54,7 @@ jobs:
       hasSwaggerSchemaChanges: ${{ steps.filter-backend.outputs.swagger_schema_any_modified == 'true'}}
       hasGqlSchemaChanges: ${{ steps.filter-backend.outputs.gql_schema_any_modified == 'true'}}
       hasMigrationChanges: ${{ steps.filter-backend.outputs.migration_any_modified == 'true'}}
+      hasWebApiClientRefitterInterfaceChanges: ${{ steps.filter-backend.outputs.web_api_client_refitter_interface_any_modified == 'true'}}
       hasWebApiClientChanges: ${{ steps.filter-backend.outputs.web_api_client_any_modified == 'true'}}
     steps:
       - name: Checkout
@@ -83,6 +87,8 @@ jobs:
               - '.azure/modules/containerApp/**/*'
             tests:
               - 'tests/**/*'
+            web_api_client_refitter_interface:
+              - 'src/Digdir.Library.Dialogporten.WebApiClient/Features/V1/RefitterInterface.cs'
             web_api_client:
               - 'src/Digdir.Library.Dialogporten.WebApiClient/**/*'
             swagger_schema:

diff --git a/docs/schema/V1/swagger.verified.json b/docs/schema/V1/swagger.verified.json
@@ -349,7 +349,7 @@
             "type": "string"
           },
           "value": {
-            "description": "A list of localizations for the content.",
+            "description": "A list of localizations for the content some change!",
             "items": {
               "$ref": "#/components/schemas/V1CommonLocalizations_Localization"
             },

diff --git a/src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Content/ContentValueDto.cs b/src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Content/ContentValueDto.cs
@@ -6,7 +6,7 @@ namespace Digdir.Domain.Dialogporten.Application.Features.V1.Common.Content;
 public sealed class ContentValueDto
 {
     /// <summary>
-    /// A list of localizations for the content.
+    /// A list of localizations for the content some change!
     /// </summary>
     public List<LocalizationDto> Value { get; set; } = [];