Skip to content

Commit

Permalink
ci: fix concurrency issues in release-prs (#509)
Browse files Browse the repository at this point in the history
Fixes an issue where infra and app deployment shared the same
concurrency group. One cancelling the other.


![image](https://github.com/digdir/dialogporten/assets/1777366/c27c0d66-6314-4dad-9603-8380e6615259)
  • Loading branch information
arealmaas authored Feb 29, 2024
1 parent 27334f3 commit c8dbf44
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/action-deploy-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ on:
concurrency:
# Existing runs are cancelled if someone repeatedly commits to their own Pull Request (PR). However, it does not stop others' dry runs or actual deployments from the main branch.
# Also, the cancellation does not occur on merges to the main branch. Therefore, if multiple merges to main are performed simultaneously, they will just be queued up.
group: ${{ github.workflow }}-${{ inputs.environment }}-${{ github.ref_name }}-${{ inputs.dryRun }}
group: deploy-apps-${{ inputs.environment }}-${{ github.ref_name }}-${{ inputs.dryRun }}
# if the dryrun input is true, we want to cancel any running deployments in order to not block the pipeline e.g for environment approvals
cancel-in-progress: ${{ inputs.dryRun }}
jobs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/action-deploy-infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ on:
concurrency:
# Existing runs are cancelled if someone repeatedly commits to their own Pull Request (PR). However, it does not stop others' dry runs or actual deployments from the main branch.
# Also, the cancellation does not occur on merges to the main branch. Therefore, if multiple merges to main are performed simultaneously, they will just be queued up.
group: ${{ github.workflow }}-${{ inputs.environment }}-${{ github.ref_name }}-${{ inputs.dryRun }}
group: deploy-infrastructure-${{ inputs.environment }}-${{ github.ref_name }}-${{ inputs.dryRun }}
# if the dryrun input is true, we want to cancel any running deployments in order to not block the pipeline e.g for environment approvals
cancel-in-progress: ${{ inputs.dryRun }}
jobs:
Expand Down

0 comments on commit c8dbf44

Please sign in to comment.