Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: error notification on draft creation failure #559

Open
wants to merge 1 commit into
base: release/4.0.7
Choose a base branch
from

Conversation

bhupeshappfoster
Copy link
Collaborator

Pull Request

Description:

Error notification will be shown if a draft fails to create or merge in delivered data, resulting in rollback of draft creation.

Related Issue(s):

Changes Made:

[List the changes made in this pull request to address the issue or implement the feature.]

Added:

  • Notification in draft merge/apply logic that will inform use why exactly the draft creation failed.

Changed:

Deprecated:

Removed:

Fixed:

Security:

Testing:

[Describe the testing performed to ensure the changes are functioning as expected.]

Quality Assurance (QA):

  • The code has been reviewed and approved by the QA team.
  • The changes have been tested on different environments (e.g., staging, production).
  • Integration tests have been performed to verify the interactions between components.
  • Performance tests have been conducted to ensure the changes do not impact system performance.
  • Any necessary database migrations or data transformations have been executed successfully.
  • Accessibility requirements have been considered and tested (e.g., screen reader compatibility, keyboard navigation).

Resources:

Screenshots (if applicable):
[Include any relevant screenshots to visually demonstrate the changes.]

Wrapping up

Checklist:

  • The code builds without any errors or warnings.
  • The code follows the project's coding conventions and style guidelines.
  • Unit tests have been added or updated to cover the changes made.
  • The documentation has been updated to reflect the changes (if applicable).
  • All new and existing tests pass successfully.
  • The PR has been reviewed by at least one other team member.

Additional Notes:
[Include any additional notes, considerations, or context that may be relevant.]

@MerrittBoydston
Copy link
Collaborator

@qa-mukesh - same thing as the other one, can you please review and follow up with @bhupeshappfoster on any questions?

Copy link
Collaborator

@qa-mukesh qa-mukesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhupeshappfoster This is not working.

Draft entry: https://dev.acclarocraft.com/admin/entries/homepage/20-homepage?site=default&draftId=2064#tab01-content

Order: https://dev.acclarocraft.com/admin/translations/orders/detail/94505?site=default#files

I updated/translated content heading and seo title in the XML file. Changes are not reflecting once these are merged into draft.

@bhupeshappfoster
Copy link
Collaborator Author

bhupeshappfoster commented Feb 4, 2025

@bhupeshappfoster This is not working.

Draft entry: https://dev.acclarocraft.com/admin/entries/homepage/20-homepage?site=default&draftId=2064#tab01-content

Order: https://dev.acclarocraft.com/admin/translations/orders/detail/94505?site=default#files

I updated/translated content heading and seo title in the XML file. Changes are not reflecting once these are merged into draft.

Hi @qa-mukesh

I tested it on dev and seems it works well, refer this order https://dev.acclarocraft.com/admin/translations/orders/detail/94517?site=default#files

Can you please test again with a fresh order

Also added updates to the ticket on expected behaviour https://github.com/AcclaroInc/pm-craft-translations/issues/576#issuecomment-2634133901.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants