Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Restore OIIO_NAMESPACE_USING #4603

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

brechtvl
Copy link
Contributor

Description

This got lost with the 2-level namespace changes in #4567, but is used by e.g. OpenUSD. Might as well not break the API here.

Tests

N/A

Checklist:

  • I have read the contribution guidelines.
  • I have updated the documentation, if applicable. (Check if there is no
    need to update the documentation, for example if this is a bug fix that
    doesn't change the API.)
  • I have ensured that the change is tested somewhere in the testsuite
    (adding new test cases if necessary).
  • If I added or modified a C++ API call, I have also amended the
    corresponding Python bindings (and if altering ImageBufAlgo functions, also
    exposed the new functionality as oiiotool options).
  • My code follows the prevailing code style of this project. If I haven't
    already run clang-format before submitting, I definitely will look at the CI
    test that runs clang-format and fix anything that it highlights as being
    nonconforming.

This got lost with the 2-level namespace changes in AcademySoftwareFoundation#4567, but is used by
e.g. OpenUSD. Might as well not break the API here.

Signed-off-by: Brecht Van Lommel <[email protected]>
Copy link
Collaborator

@lgritz lgritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry about that.

@lgritz lgritz merged commit 9979a27 into AcademySoftwareFoundation:main Jan 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants