Skip to content

Fix problem of blocking due to ch when StopAll is called. #176

Fix problem of blocking due to ch when StopAll is called.

Fix problem of blocking due to ch when StopAll is called. #176

Triggered via pull request March 6, 2024 01:06
Status Success
Total duration 1m 49s
Artifacts

ci.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

20 errors and 2 warnings
Test: diskcache.go#L93
[gostyle.contexts] Don't add a Context member to a struct type; instead add a ctx parameter to each method on that type that needs to pass it along. The one exception is for methods whose signature must match an interface in the standard library or in a third party library. (ref: https://go.dev/wiki/CodeReviewComments#contexts ): adjustStopCtx
Test: diskcache.go#L95
[gostyle.contexts] Don't add a Context member to a struct type; instead add a ctx parameter to each method on that type that needs to pass it along. The one exception is for methods whose signature must match an interface in the standard library or in a third party library. (ref: https://go.dev/wiki/CodeReviewComments#contexts ): warmUpStopCtx
Test: rcutil_test.go#L189
[gostyle.dontpanic] Don't use panic for normal error handling. Use error and multiple return values. (ref: https://go.dev/wiki/CodeReviewComments#dont-panic )
Test: diskcache.go#L404
[gostyle.funcfmt] Function and method calls should not be separated based solely on line length. (ref: https://google.github.io/styleguide/go/decisions#function-formatting )
Test: diskcache.go#L233
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test: diskcache.go#L282
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test: diskcache.go#L342
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test: diskcache.go#L450
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test: testutil/cacher.go#L76
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test: testutil/container.go#L51
[gostyle.handlerrors] Do not discard errors using `_` variables. If a function returns an error, check it to make sure the function succeeded. Handle the error, return it, or, in truly exceptional situations, panic. (ref: https://go.dev/wiki/CodeReviewComments#handle-errors )
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Cannot open: File exists
Test
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2