Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 4.2.0 breaks builds #95

Closed
CelsoSantos opened this issue Sep 4, 2017 · 1 comment
Closed

[BUG] 4.2.0 breaks builds #95

CelsoSantos opened this issue Sep 4, 2017 · 1 comment

Comments

@CelsoSantos
Copy link

Hello,

The latest version seems to break the builds, at least with Ionic App Scripts v1.2.2.

Error output:

+ npm run build

> com.brandbassador@ build /var/lib/jenkins/workspace/STG-IonicApp
> node --max-old-space-size=2048 ./node_modules/.bin/ionic-app-scripts build

[14:52:39]  ionic-app-scripts 1.2.2 
[14:52:39]  build dev started ... 
[14:52:39]  clean started ... 
[14:52:39]  clean finished in 1 ms 
[14:52:39]  copy started ... 
[14:52:39]  transpile started ... 
[14:52:46]  typescript: node_modules/ionic-image-loader/dist/components/img-loader.d.ts, line: 1 
            Module '"/var/lib/jenkins/workspace/STG-IonicApp/node_modules/@angular/core/index"' has no exported member 
            'Renderer2'. 

       L1:  import { ElementRef, Renderer2, OnInit, EventEmitter } from '@angular/core';
       L2:  import { ImageLoader } from '../providers/image-loader';

[14:52:46]  ionic-app-script task: "build" 
[14:52:46]  Error: Failed to transpile program 
Error: Failed to transpile program
    at BuildError.Error (native)
    at new BuildError (/var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/util/errors.js:16:28)
    at /var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/transpile.js:102:20
    at transpileWorker (/var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/transpile.js:68:12)
    at Object.transpile (/var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/transpile.js:26:12)
    at buildProject (/var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/build.js:98:78)
    at /var/lib/jenkins/workspace/STG-IonicApp/node_modules/@ionic/app-scripts/dist/build.js:46:16

Ionic Info:

[jenkins@bb-jenkins STG-IonicApp]$ ionic info

Your system information:

Cordova CLI: 6.5.0
Ionic Framework Version: 2.0.1
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.2.2
ios-deploy version: Not installed
ios-sim version: Not installed
OS: Linux 3.10
Node Version: v6.6.0
Xcode version: Not installed
@ihadeed
Copy link
Member

ihadeed commented Sep 5, 2017

I think Renderer2 was introduced in Angular 4.x, and IIRC [email protected] uses Angular 2.x

I'll replace Renderer with Renderer and publish a new release soon.

@ihadeed ihadeed closed this as completed in 316fcb9 Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants