Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotImplementedError: DST transitions are not implemented #35

Open
zxdavb opened this issue Mar 9, 2025 · 1 comment
Open

NotImplementedError: DST transitions are not implemented #35

zxdavb opened this issue Mar 9, 2025 · 1 comment

Comments

@zxdavb
Copy link
Owner

zxdavb commented Mar 9, 2025

Time zones (TZs) are difficult, but are needed for (e.g.) knowing when daylight savings time (DST) starts & stops.

This library makes much effort to recognize the TZ of each evohome location, but:

  • the vendor API appears to use Windows TZs, e.g. Central Europe Standard Time, while
  • the library uses IANA TZs internally, e.g. Europe/Budapest

If evohome-async cannot map the location's TZ to a IANA equivalent, it creates a bespoke TZ, and you'll see a warning:

Unable to find IANA TZ identifier for 'RandomStandardTime'; DST support will be very limited

Unfortunately, in these cases it cannot know when DST starts/stops, so if the location has DST enabled, you'll see:

NotImplementedError: DST transitions are not implemented

Workarounds include:

  1. switching to a supported TZ, see src/evohome/windows_zones.py, or:
  2. disabling DST
@zxdavb
Copy link
Owner Author

zxdavb commented Mar 9, 2025

See a specific example of this behaviour: home-assistant/core#140194

Note that NA/SA TZs have now been added, and South American TZs should now be OK to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant