Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] UI freezes up with huge/massive collection #89

Closed
fatflyingpigs opened this issue Mar 30, 2023 · 3 comments · Fixed by #281
Closed

[Bug] UI freezes up with huge/massive collection #89

fatflyingpigs opened this issue Mar 30, 2023 · 3 comments · Fixed by #281
Assignees

Comments

@fatflyingpigs
Copy link

RomM version
V1.5

Describe the bug
When attempting to load a platform with a large number of entries, there is a huge lag.
700 entries: takes 1-5 seconds, loads smoothly
8500 entires: takes 60+ seconds, sometimes Chrome will prompt to terminate the tab. Scrolling down quickly seems to lazy load the image for each game (in this case, 'cover missing' for most of them).

To Reproduce

  1. Have two folders, folder 'ds' has 1 file and folder 'gba' 8500 files. Scan the files.
  2. After the scan, click on the 'ds' section. Then click on the 'gba' section and wait for the lag.

Expected behavior
It would be nice if large collections could be loaded lazily, instead of the page trying to fetch every game at once. Actually, the implementation doesn't really matter - I'd just like the page to load faster, even if the cover images load in later.

Desktop (please complete the following information):
Windows 10, Chrome v109.0.5414.75

@zurdi15
Copy link
Member

zurdi15 commented Apr 4, 2023

I agree with the implementation details. For large collections there should be a lazy scroll load

@w00tlarr
Copy link

w00tlarr commented Nov 4, 2023

Hey. Hi. I actually love the simplicity of this app. But hmm... do I need to do something for pagination to really paginate? When I reach to the bottom at 60 at listview.. it keeps increasing the from 60 to 120 and the pagination UI went down and keeps going down and down after +60. It's not really a pagination list with left/right arrow to use but more an appended infinite list. I can't also set to filter by X number as it just says All in the dropdown.

@zurdi15
Copy link
Member

zurdi15 commented Nov 4, 2023

Yes you are right with that is not really a pagination, it's a infinite scroll, with 60 games loaded each time. It's meant to use with the filter by name and was made to avoid loading large collections.

The feature to "jump" directly to X page is not implemented yet, like in a usual data table like this one.

Would be nice if you can open an issue to ask for a "real" pagination in the data table to keep the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants