Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[debug build][Android] layout: Screen content is not scrollable when keyboards pops. #2981

Open
jainkuniya opened this issue Sep 20, 2018 · 12 comments

Comments

@jainkuniya
Copy link
Member

jainkuniya commented Sep 20, 2018

[Note: This issue has only been seen on debug builds of the app, which makes it a low priority. If you see it on a release build, please comment!]


Example: In realmScreen, on medium size phone. When url input is focused, input doesn't move to top making space for keyboard. So just after entering url, one need to press back button to hide keyboard and then then he can see Enter button.

image

@zulipbot claim

@jainkuniya
Copy link
Member Author

I can only reproduce it on Emulator (Google pixel, API 26), but can't on my physical device (One plus 6, API 26).

Also on the emulator on current master I can reproduce
image

@borisyankov
Copy link
Contributor

I'd suggest again to test on RN 0.57 :)

@jainkuniya
Copy link
Member Author

I'd suggest again to test on RN 0.57 :)

I tested on #2955, still can reproduce on Pixel 2 emulator and this time on my Android physical device too.

@gnprice gnprice added a-layout and removed a-layout labels Oct 23, 2018
@gnprice
Copy link
Member

gnprice commented Jun 12, 2019

WFM in 25.4.118, on a Pixel 2 XL with Android 9. (With the display scaled way up in system settings, so that there's not a lot of room.)

@jainkuniya , would you try again to reproduce with a current version? Perhaps we've fixed it since the original report.

@jainkuniya
Copy link
Member Author

Still can reproduce on 0b8920a (upstream/master) on Android Pixel Genymotion emulator Android 9.
image

But can't on my physical One plus six Android 9.

This is not even reproducible even after clearing storage and restarting app.

And it is only reproducible on first launch of the app, from subsequent launches it works fine.
image

I think we should close this issue. In case if some user reports similar issue then we can resume on this.

@gnprice
Copy link
Member

gnprice commented Jun 17, 2019

Thanks @jainkuniya !

I think actually your screenshot doesn't match the original report of this issue. If you look back at the top of this thread, you'll see you wrote there:

When url input is focused, input doesn't move to top making space for keyboard. So just after entering url, one need to press back button to hide keyboard and then then he can see Enter button.

And the screenshot shows the app with the app bar still visible as normal, and the URL input field hasn't moved up appropriately.

Whereas in your screenshot above (of the bad case), the app bar isn't visible -- it's as if it's been pushed up above the screen. The compose box has also been pushed upward... though not quite as much as it should be.

Take a look at #3010. I think the issue you're seeing in that recent screenshot matches that issue exactly.

Looking closer at your later screenshots above, from after the original report: they also look like #3010 and your most recent screenshot.


So, those later reports look like a dupe of #3010.

I'm still interested in confirming that the original issue is gone, though -- the one in the original description and screenshot. Would you try reproducing it, on the same screen that that original description is about?

@jainkuniya
Copy link
Member Author

I thought both are similar issue and was thinking that we are tracking both here. (as both are reproducible on emulator on first launch).

Yup! original issue is still reproducible on emulator, debug build on first launch. Can also reproduce it (along with #3010) on my physical device on first launch in debug mode.

@gnprice
Copy link
Member

gnprice commented Jun 19, 2019

Hmm -- well, one key fact about #3010 is that it's only ever been seen in debug mode.

Can you reproduce this one in release mode?

@gnprice
Copy link
Member

gnprice commented Jun 19, 2019

If this one turns out to be debug-mode-only, then we'll deprioritize it (just like #3010) and focus on other things.

If it turns out to affect release mode, then it's something that potentially affects many users' onboarding and first impressions, and we'll want to debug some more.

@jainkuniya
Copy link
Member Author

Can you reproduce this one in release mode?

Nope, I can only reproduce it in debug mode.

@jainkuniya jainkuniya changed the title [Android] layout: Screen content is not scrollable when keyboards pops. [debug build][Android] layout: Screen content is not scrollable when keyboards pops. Jun 20, 2019
@jainkuniya
Copy link
Member Author

Updated title and issue, to reflect it is only on debug build.

@gnprice
Copy link
Member

gnprice commented Jun 20, 2019

Cool. Thanks for checking that! We'll leave this open but basically treat it as bottom-priority to debug any further, then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants