Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify instructions for wf step - fixed #4084 #4167

Closed
wants to merge 5 commits into from

Conversation

vlameli
Copy link
Contributor

@vlameli vlameli commented Feb 3, 2025

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe:

Relevant issues

Changes proposed in this PR

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link

github-actions bot commented Feb 3, 2025

build 6904 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13113558000

Copy link

github-actions bot commented Feb 3, 2025

Test workflow 6064 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.1.0-PR-4167/zowe-3.1.0-pr-4167-6904-20250203123656.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13113639661

@MarkAckert
Copy link
Member

Regarding the original issue #4084... is the workflow unable to supply customizations to ZWESECUR? For some fields or all of them? If the user should review the ZWESECUR JCL, where would they find it? What should they look to customize?

@vlameli vlameli closed this Feb 5, 2025
@vlameli vlameli reopened this Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

build 6923 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13156740734

Copy link

github-actions bot commented Feb 5, 2025

build 6924 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13156742929

Copy link

github-actions bot commented Feb 5, 2025

Test workflow 6076 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4167/zowe-3.2.0-pr-4167-6924-20250205115717.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13156824528

Copy link

github-actions bot commented Feb 5, 2025

Test workflow 6077 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4167/zowe-3.2.0-pr-4167-6923-20250205115836.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13156841401

@vlameli
Copy link
Contributor Author

vlameli commented Feb 5, 2025

> Regarding the original issue #4084... is the workflow unable to supply customizations to ZWESECUR? For some fields or all of them? If the user should review the ZWESECUR JCL, where would they find it? What should they look to customize?

@MarkAckert Previously, I did the changes based on note in the issue "instruct users to review and edit this JCL", but when I looked on it again in more details, I think there should not be any customization needed.
Workflow is using "zwe init security" command that will take care about it.
The comments in the JCL, that are highlighted in the issue are there if the script driven scenarios is not used.
I added the name of dataset where to find the JCL, if someone would like to review it anyway...

@vlameli vlameli requested a review from MarkAckert February 5, 2025 12:45
Copy link

github-actions bot commented Feb 14, 2025

build 7016 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13324151282

Copy link

github-actions bot commented Feb 14, 2025

Test workflow 6123 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4167/zowe-3.2.0-pr-4167-7016-20250214070039.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/13324199951

@vlameli vlameli closed this Feb 14, 2025
@vlameli
Copy link
Contributor Author

vlameli commented Feb 14, 2025

Will add comment to the issue itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants