Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Validate that zowe.config.json file matches schema #74

Closed
Tracked by #148
t1m0thyj opened this issue Jun 7, 2022 · 3 comments · Fixed by #192
Closed
Tracked by #148

[core] Validate that zowe.config.json file matches schema #74

t1m0thyj opened this issue Jun 7, 2022 · 3 comments · Fixed by #192
Assignees
Labels
enhancement New feature or request priority-medium team-config Zowe v2 team configuration

Comments

@t1m0thyj
Copy link
Member

t1m0thyj commented Jun 7, 2022

Given a zowe.config.json file that references a zowe.schema.json file, validate that the contents of the JSON file conform to the schema.

@t1m0thyj t1m0thyj added the team-config Zowe v2 team configuration label Jun 7, 2022
@t1m0thyj t1m0thyj added this to the Zowe v2 Team Configuration milestone Jun 9, 2022
@t1m0thyj
Copy link
Member Author

In #116 a new method was added to validate config files against a JSON schema. There are some further enhancements to make:

  • Automatically detect schema filename from $schema property in the config file - can be a file path or Internet URL
  • Move the validation logic into the ProfileManager class as opt-in behavior to auto-validate when profiles are loaded

@zFernand0 zFernand0 added enhancement New feature or request priority-medium labels Mar 9, 2023
@Aman123lug
Copy link
Contributor

Hello Sir, I am Applying for Zowe Python SDK Enhancements for this project. Is any number of PRs required in order to become a mentee

@t1m0thyj
Copy link
Member Author

  • Missing $schema property - warning?
  • Invalid $schema property - error?
  • Valid $schema property - throw errors for any validation fails
  • Have flag to disable schema validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-medium team-config Zowe v2 team configuration
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants