Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up after dropping support for Net::IP #1129

Closed
mattias-p opened this issue Sep 16, 2022 · 3 comments · Fixed by #1202
Closed

Clean up after dropping support for Net::IP #1129

mattias-p opened this issue Sep 16, 2022 · 3 comments · Fixed by #1202
Labels
P-High Priority: Issue to be solved before other
Milestone
v2023.1

Comments

@mattias-p
Copy link
Member

mattias-p commented Sep 16, 2022 •
edited
Loading

After we drop support for Net::IP in favor of Net::IP::XS in #1119 there are some things we need to clean up.

We need to take care of dependencies for new installations and upgrades. Also, the whole purpose of Zonemaster::Engine::Net::IP is gone so it should be deprecated and eventually removed.

  • The installation instructions should be updated install Net::IP::XS instead of Net::IP. (Replaces Net::IP by Net::IP::XS in installation #1130)
  • An upgrade instruction should be added directing users to install Net::IP::XS when upgrading to the new version of Zonemaster::Engine.
  • The API documentation for Zonemaster::Engine::Net::IP should state clearly that the module is deprecated and that it will be removed. It should also encourage people to migrate their code to use Net::IP::XS directly instead.
@mattias-p mattias-p added this to the v2022.2 milestone Sep 16, 2022
@mattias-p mattias-p changed the title Deprecate Zonemaster::Engine::Net::IP Clean up after dropping support for Net::IP Sep 16, 2022
@mattias-p mattias-p added the P-High Priority: Issue to be solved before other label Sep 16, 2022
This was referenced Sep 16, 2022
Merged
Merged
@matsduf
Copy link
Contributor

matsduf commented Sep 16, 2022 •
edited
Loading 

* The installation instructions should be updated install Net::IP::XS instead of Net::IP.

See #1130.

@matsduf matsduf modified the milestones: v2022.2, v2023.1 Dec 20, 2022
@ghost ghost mentioned this issue Feb 27, 2023
Merged
@ghost ghost linked a pull request Feb 27, 2023 that will close this issue
Deprecate Zonemaster::Engine::Net::IP module #1202
Merged
@ghost
Copy link

ghost commented Feb 27, 2023

  • The API documentation for Zonemaster::Engine::Net::IP should state clearly that the module is deprecated and that it will be removed.

Done with #1202

@matsduf matsduf modified the milestones: v2023.1, v2023.2 Jun 26, 2023
@matsduf matsduf modified the milestones: v2023.2, v2024.1 Mar 19, 2024
@matsduf matsduf modified the milestones: v2024.1, v2024.2 Jul 3, 2024
@tgreenx
Copy link
Contributor

tgreenx commented Sep 17, 2024

Solved in release v2023.1 by #1130 and #1202.

@tgreenx tgreenx closed this as completed Sep 17, 2024
@tgreenx tgreenx modified the milestones: v2024.2, v2023.1 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-High Priority: Issue to be solved before other
Projects
None yet
Milestone
v2023.1
Development

Successfully merging a pull request may close this issue.

Deprecate Zonemaster::Engine::Net::IP module
3 participants
@mattias-p @matsduf @tgreenx