Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long severity level translations break table layout in output #334

Closed
mattias-p opened this issue May 30, 2023 · 1 comment · Fixed by #335
Closed

Long severity level translations break table layout in output #334

mattias-p opened this issue May 30, 2023 · 1 comment · Fixed by #335
Labels
T-Bug Type: Bug in software or error in test case description
Milestone
v2023.1

Comments

@mattias-p
Copy link
Member

Today the width of the severity column is calculated using a minimum width and the length of the translation of the severity column heading. However for some locales there are severity level names that are even longer. When messages are printed with such severity levels the table layout breaks down. E.g. when "WARNING" messages are printed in Spanish ("ADVERTENCIA").

A robust fix would be to calculate the width of the severity column by taking the maximum length of all the severities as well as the heading.

I guess it would be nice to have this fixed in this release (2023.1) but I don't think we should consider it blocking.
@mattias-p mattias-p added this to the v2023.1 milestone May 30, 2023
@mattias-p mattias-p added the T-Bug Type: Bug in software or error in test case description label May 30, 2023
@mattias-p mattias-p mentioned this issue May 30, 2023
Merged
@ghost ghost mentioned this issue May 30, 2023
Merged
@tgreenx tgreenx linked a pull request May 30, 2023 that will close this issue
Fix table layout #335
Merged
@matsduf
Copy link
Contributor

matsduf commented Jun 7, 2023

Fixed by #335

@matsduf matsduf closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-Bug Type: Bug in software or error in test case description
Projects
None yet
Milestone
v2023.1
Development

Successfully merging a pull request may close this issue.

Fix table layout
2 participants
@mattias-p @matsduf