LegacyIteratorNext issue with iterators.

[romainmenke]

core-js/packages/core-js/internals/array-from.js

Line 27 in cc5b386

for (;!(step = next.call(iterator)).done; index++) {

Run through babel + core-js.
Test in older firefox (43 has the error)

const url = new URL(
	'https://u:[email protected]:8080/some/path?foo=true&bar=true#frag'
);

Array.from(url.searchParams.entries());

Result :

Page will freeze with an infinite loop.

---

Caused by : https://github.com/mozilla/gecko-dev/blob/0f254a30d684796bcc8b6e2a102a0095d25842bb/js/src/builtin/Iterator.js#L14

Hacky way to circumvent :

next = iterator.next;
var isLegacyIteratorNext = next.name === 'LegacyIteratorNext';
result = new C();
for (;!(step = (isLegacyIteratorNext ? next.call(iterator).value : next.call(iterator))).done; index++) {
  value = mapping ? callWithSafeIterationClosing(iterator, mapfn, [step.value, index], true) : step.value;
  createProperty(result, index, value);

  if (index > 150) { // how to detect the infinite loop
    throw new Error('panic');
  }
}

---

Unsure what changed.
We started seeing this error a couple of weeks ago but it might have always been there and maybe didn't get reported.

[zloirock]

core-js does not use native URL and URLSearchParams in FF43, they should overwritten in FF57-. Make sure that you load all required modules.

[romainmenke]

This is with the overwritten URL and URLSearchParams (i think).

modules by path ../../../node_modules/core-js/internals/*.js 51.6 KiB 81 modules
modules by path ../../../node_modules/core-js/modules/*.js 48.9 KiB
  ../../../node_modules/core-js/modules/es.array.from.js 433 bytes [built] [code generated]
  ../../../node_modules/core-js/modules/es.array.iterator.js 2.1 KiB [built] [code generated]
  ../../../node_modules/core-js/modules/es.object.to-string.js 380 bytes [built] [code generated]
  ../../../node_modules/core-js/modules/es.string.iterator.js 1.01 KiB [built] [code generated]
  ../../../node_modules/core-js/modules/web.dom-collections.iterator.js 1.53 KiB [built] [code generated]
  ../../../node_modules/core-js/modules/web.url.js 31.9 KiB [built] [code generated]
  ../../../node_modules/core-js/modules/web.url-search-params.js 11.6 KiB [built] [code generated]

babel config :

module: {
	rules: [
		{
			test: /\.js$/,
			exclude: /(node_modules)/,
			use: {
				loader: 'babel-loader',
				options: {
					comments: false,
					presets: [
						[
							'@babel/preset-env',
							{
								corejs: '^3.6.3',
								targets: {
									browsers: [ 'chrome >= 26', 'edge >= 12', 'firefox >= 26', 'opera >= 26', 'safari >= 6', 'ie >= 8' ],
								},
								useBuiltIns: 'usage'
							}
						]
					]
				}
			}
		}
	]
}

[romainmenke]

A minimal project that reproduces the issue :

https://github.com/romainmenke/legacy-iterator-next

When visiting the page in Firefox 43 :

---

update

Also added a log to make sure URLSearchParams uses the polyfill iterator next and it does.

[romainmenke]

Thank you @zloirock for taking the time to look into this and for having a fix so quickly!
Really appreciate all the hard work that goes into this project!