Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it really necessary to pop up the output panel when typechecking a file? #109

Closed
be5invis opened this issue May 5, 2017 · 18 comments
Closed
Assignees

Comments

@be5invis
Copy link
Collaborator

be5invis commented May 5, 2017

No description provided.

@swr1bm86
Copy link
Owner

swr1bm86 commented May 5, 2017

@be5invis Yes, I also considered switching to a new way to display the type checking result, one possible way is to show problem panel when the type checking process failed, but it is still pending microsoft/vscode#22885 I think, and another way is to show the result on status bar which is already implemented #106, but I haven't released this feature yet since I got some problem with vsce.

@swr1bm86
Copy link
Owner

swr1bm86 commented May 5, 2017

What do you have in mind is the best way to show the type checking result?

@czhang03
Copy link

czhang03 commented May 5, 2017

I would give a +1 to the problem panel (and I did)

@swr1bm86
Copy link
Owner

swr1bm86 commented May 6, 2017

@chantisnake problem panel is supposed to be the best solution here indeed, but we still have to wait it appears in the next release of VSCode.

@be5invis
Copy link
Collaborator Author

be5invis commented May 6, 2017

maybe a 👍 👎 icon like this?
https://marketplace.visualstudio.com/items?itemName=roscaj.dafny-vscode

@czhang03
Copy link

czhang03 commented May 6, 2017

I think @be5invis idea is generally valid for now. Idris atom uses a method like this (a notification in the status bar)

@swr1bm86
Copy link
Owner

swr1bm86 commented May 6, 2017

@be5invis @chantisnake OK, thanks for the reference, I will remove the stupid output channel and use the thumb icons.

@swr1bm86
Copy link
Owner

swr1bm86 commented May 6, 2017

So it is also no need to display the type checking errors in output channel right? cause we can check all the warnings and errors in problem panel.

@czhang03
Copy link

czhang03 commented May 6, 2017

I think so.

@swr1bm86 swr1bm86 self-assigned this May 6, 2017
@ndmitchell
Copy link

I found the forced switch to output to be exceptionally annoying since I was quickly doing other stuff in another terminal window. I would definitely like this to be eliminated.

@swr1bm86
Copy link
Owner

swr1bm86 commented May 7, 2017

@ndmitchell I will address issue ASAP :)

@swr1bm86
Copy link
Owner

swr1bm86 commented May 7, 2017

  • Add option to turn off stupid output channel.
    - [ ] Using thumb icons.
    - [ ] Add a preview HTML page to display errors. I can't remember what exactly in my mind three weeks ago.

@ndmitchell
Copy link

Note that the thing that broke my flow was forced switching to the output channel - actually having the output channel wasn't problematic.

@be5invis
Copy link
Collaborator Author

be5invis commented May 7, 2017

@zjhmale @ndmitchell Add an option for that, "showOutputWhenTypechecking"

@swr1bm86
Copy link
Owner

swr1bm86 commented May 8, 2017

@be5invis Thanks, adding an option is on the todo list already.

@swr1bm86
Copy link
Owner

Hi @ndmitchell @be5invis @chantisnake Sorry for the huge delay, I was busy with something else these days, the showOutputWhenTypechecking option is already added and default to false, the new release will be tonight or tomorrow, Cheers!

@pandemonium
Copy link

When showOutputWhenTypechecking is false, saving the file or activating the idris.typecheck command does not actually type-check the file. This is a bug but since there is a discussion about it here I thought I'd mention it.

@swr1bm86
Copy link
Owner

@pandemonium Thanks, I will address it. There is also a bug of Github that I just got the notification of your comment with a huge delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants