-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jQuery forward compatibility layer for Zikula 1.4.x #844
Comments
I tested my suggestion with the system settings module. Here what I have done:
After that I could load the multilingual settings page without prototype and scriptaculous. |
I like this idea. But we should know that this will require a lot of work with every system module and replacing each and every script with jQuery version. Working on 1.4 I've made jQuery versions of core javascript libraries. This could be the base for this layer. |
Yes it is, but for 1.4 we have to do this work anyway. Prototype wont work anymore if you want to use jQuery with $. We could even think about to do the migration step by step (1.3.6, 1.3.7, ...) and mark the jQuery option as experimental.
Definitely. I saw you want to use underscore, modernizr, polyfills. I think this is a good base. |
bump |
Now we have seriously integrated jQuery/Bootstrap, are there any more thoughts or changed opinions now? |
renamed from |
IMHO this can be closed, since we have agreed about future JS directions and can use Please confirm or deny. |
What we can do is to convert all zikula helpers to jquery. I think @jusuff made already a nice beginning of that. But the question is if we have time for it. @jusuff or what are your ideas? |
@jusuff it would be great if could talk about your plans and the time you want to invest. |
I've added the 'blocker' tag only as a means of promoting more immediate discussion/work. This may not truly be a blocker however. |
I would to discard this idea. I think the only good way to offer an prototype compatibility (without any problems) is to use jQuery noConflict. IMHO I would use noConflict even in Zikula 2.0.0. This would allow to offer an prototype/zikula-helpers package. So I suggest to close this topic. |
I agree! |
I agree also, but I wish someone would tackle the work of migrating existing needed scripts from prototype to jquery... |
👍 |
I can't promise anything at the moment, but I will try to proceed on #1214 soon. |
Starting position
Zikula 1.4 and all later version will use jQuery as standard. By technical reason there is no noconflict for prototype.js. This means we have to drop prototype.js and all prototype.js javascript in Zikula (core, modules, ...)
The problems
My suggestion
Add a jQuery forward compatibility layer to Zikula 1.4
How will it work
Questions
Yes jQuery will use (like now) noConflict. So a mixture is still possible. This is also valid for the other way around.
There are two possibilities: 1. By a smarty if or by using an external js.
Benefits of this solution
The text was updated successfully, but these errors were encountered: