Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zig build should omit empty directories when all files in a directory are filtered out during recursive install #3431

Open
Rocknest opened this issue Oct 10, 2019 · 3 comments
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig build system std.Build, the build runner, `zig build` subcommand, package management
Milestone

Comments

@Rocknest
Copy link
Contributor

I checked both linux and windows binaries and they have empty std/json/* and std/unicode/*

@andrewrk andrewrk added the zig build system std.Build, the build runner, `zig build` subcommand, package management label Oct 11, 2019
@andrewrk andrewrk added this to the 0.6.0 milestone Oct 11, 2019
@andrewrk
Copy link
Member

This is actually ok, it is avoiding installing test files:

The issue here is actually that it is not omitting an empty directory.

@andrewrk andrewrk changed the title Some files in zig binaries are missing zig build should omit empty directories when all files in a directory are filtered out during recursive install Oct 11, 2019
@Rocknest
Copy link
Contributor Author

Rocknest commented Oct 11, 2019

Now these files may be useful (running std tests to generate docs)

@andrewrk
Copy link
Member

I agree that we either need to ship pre-built std lib docs or the test files. The compiler_rt tests, in particular, total 11.7 MiB, which is greater than the size of the pre-built std lib docs. Since the process for building std lib docs will be a bit complicated, and take some time, I think I will prefer to ship std lib docs for now.

For working on doc generation, as you are doing in #3429, it is reasonable to require a source checkout.

@andrewrk andrewrk added the proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. label Feb 18, 2020
@andrewrk andrewrk modified the milestones: 0.6.0, 0.7.0 Feb 18, 2020
@andrewrk andrewrk modified the milestones: 0.7.0, 0.8.0 Oct 27, 2020
@andrewrk andrewrk modified the milestones: 0.8.0, 0.9.0 May 19, 2021
@andrewrk andrewrk modified the milestones: 0.9.0, 0.10.0 Nov 23, 2021
@andrewrk andrewrk modified the milestones: 0.10.0, 0.11.0 Apr 16, 2022
@andrewrk andrewrk modified the milestones: 0.11.0, 0.12.0 Jun 19, 2023
@andrewrk andrewrk added enhancement Solving this issue will likely involve adding new logic or components to the codebase. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. and removed proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. labels Jul 26, 2024
@andrewrk andrewrk modified the milestones: 0.14.0, 0.16.0 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor friendly This issue is limited in scope and/or knowledge of Zig internals. enhancement Solving this issue will likely involve adding new logic or components to the codebase. zig build system std.Build, the build runner, `zig build` subcommand, package management
Projects
None yet
Development

No branches or pull requests

2 participants