Skip to content

Commit d34a171

Browse files
GDsouzazgagnon
authored andcommitted
Fix lower cpi bound on PMW33XX (qmk#22108)
1 parent d768743 commit d34a171

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

drivers/sensors/pmw3320.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ uint16_t pmw3320_get_cpi(void) {
178178
}
179179

180180
void pmw3320_set_cpi(uint16_t cpi) {
181-
uint8_t cpival = constrain((cpi / PMW3320_CPI_STEP) - 1U, 0, (PMW3320_CPI_MAX / PMW3320_CPI_STEP) - 1U);
181+
uint8_t cpival = constrain((cpi / PMW3320_CPI_STEP), (PMW3320_CPI_MIN / PMW3320_CPI_STEP), (PMW3320_CPI_MAX / PMW3320_CPI_STEP)) - 1U;
182182
// Fifth bit is probably a control bit.
183183
// PMW3320 datasheet don't have any info on this, so this is a pure guess.
184184
pmw3320_write_reg(REG_Resolution, 0x20 | cpival);

drivers/sensors/pmw3360.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ void pmw33xx_set_cpi(uint8_t sensor, uint16_t cpi) {
2323
return;
2424
}
2525

26-
uint8_t cpival = CONSTRAIN((cpi / PMW33XX_CPI_STEP) - 1, 0, (PMW33XX_CPI_MAX / PMW33XX_CPI_STEP) - 1U);
26+
uint8_t cpival = CONSTRAIN((cpi / PMW33XX_CPI_STEP), (PMW33XX_CPI_MIN / PMW33XX_CPI_STEP), (PMW33XX_CPI_MAX / PMW33XX_CPI_STEP)) - 1U;
2727
pmw33xx_write(sensor, REG_Config1, cpival);
2828
}
2929

drivers/sensors/pmw3389.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ void pmw33xx_set_cpi(uint8_t sensor, uint16_t cpi) {
2222
return;
2323
}
2424

25-
uint16_t cpival = CONSTRAIN((cpi / PMW33XX_CPI_STEP) - 1, 0, (PMW33XX_CPI_MAX / PMW33XX_CPI_STEP) - 1U);
25+
uint16_t cpival = CONSTRAIN((cpi / PMW33XX_CPI_STEP), (PMW33XX_CPI_MIN / PMW33XX_CPI_STEP), (PMW33XX_CPI_MAX / PMW33XX_CPI_STEP)) - 1U;
2626
// Sets upper byte first for more consistent setting of cpi
2727
pmw33xx_write(sensor, REG_Resolution_H, (cpival >> 8) & 0xFF);
2828
pmw33xx_write(sensor, REG_Resolution_L, cpival & 0xFF);

0 commit comments

Comments
 (0)