Skip to content

Commit 906889f

Browse files
zvecrzgagnon
authored andcommitted
Fix parsing/validation for 21939 (qmk#22148)
1 parent f0d4415 commit 906889f

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

data/schemas/keyboard.jsonschema

+2-2
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,7 @@
404404
"speed_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"},
405405
"led_flush_limit": {"$ref": "qmk.definitions.v1#/unsigned_int"},
406406
"led_process_limit": {"$ref": "qmk.definitions.v1#/unsigned_int"},
407-
"react_on_keyup": {"$ref": "qmk.definitions.v1#/unsigned_int"},
407+
"react_on_keyup": {"type": "boolean"},
408408
"sleep": {"type": "boolean"},
409409
"split_count": {
410410
"type": "array",
@@ -460,7 +460,7 @@
460460
"speed_steps": {"$ref": "qmk.definitions.v1#/unsigned_int"},
461461
"led_flush_limit": {"$ref": "qmk.definitions.v1#/unsigned_int"},
462462
"led_process_limit": {"$ref": "qmk.definitions.v1#/unsigned_int"},
463-
"react_on_keyup": {"$ref": "qmk.definitions.v1#/unsigned_int"},
463+
"react_on_keyup": {"type": "boolean"},
464464
"sleep": {"type": "boolean"},
465465
"split_count": {
466466
"type": "array",

lib/python/qmk/info.py

+2
Original file line numberDiff line numberDiff line change
@@ -520,6 +520,8 @@ def _config_to_json(key_type, config_value):
520520
return list(map(str.strip, config_value.split(',')))
521521

522522
elif key_type == 'bool':
523+
if isinstance(config_value, bool):
524+
return config_value
523525
return config_value in true_values
524526

525527
elif key_type == 'hex':

0 commit comments

Comments
 (0)