Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

will directory js publish as a npm package ? just like gltfpack #232

Closed
deepkolos opened this issue Jan 25, 2021 · 3 comments
Closed

will directory js publish as a npm package ? just like gltfpack #232

deepkolos opened this issue Jan 25, 2021 · 3 comments

Comments

@deepkolos
Copy link

npm package is more popular than source include, so please make an npm package to make this project more popular

@zeux
Copy link
Owner

zeux commented Jan 26, 2021

I could definitely set things up to be able to publish js/ folder as a standalone NPM package, e.g. meshoptimizer.

Out of curiosity, do you have a specific use in mind? I ask because the decompression code in js/ has been integrated into Babylon.JS where the code is embedded into the distribution, and into Three.JS where the code is technically part of the examples but my understanding is that if you use GLTFLoader at all you'd need to copy it into the project or use smth like unpkg.com that can also be used to get meshopt_decoder.

@deepkolos
Copy link
Author

deepkolos commented Jan 26, 2021

thx for reminding, i don't know it has been integrated into three.js, i just read the gltfpack document and don't where to import the js/meshopt_decoder.module.js from three.js's package

maybe add some notes about what location to import from three.js or Babylon.JS

three/examples/jsm/libs/meshopt_decoder.module.js

maybe publish a npm package will enable user to use older version three and newer version of meshopt_decoder

@zeux
Copy link
Owner

zeux commented Jan 26, 2021

maybe add some notes about what location to import from three.js or Babylon.JS

That's a good point, I will add a note to that effect. FWIW an example was recently added to three.js that hopefully can show the usage, see https://github.com/mrdoob/three.js/blob/dev/examples/webgl_loader_gltf_compressed.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants