Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable multiple confirmation count values in chain params #3423

Closed
lumtis opened this issue Jan 28, 2025 · 1 comment · Fixed by #3461
Closed

Enable multiple confirmation count values in chain params #3423

lumtis opened this issue Jan 28, 2025 · 1 comment · Fixed by #3461

Comments

@lumtis
Copy link
Member

lumtis commented Jan 28, 2025

We currently have a single confirmation_count used per chain to determine if a tx is confirmed on a chain.

Under some circumstances, the value can be different:

  • between inbound and outbound
  • if we want to enable fast observation and fewer confirmation (although we might still want to have a different value per chain, 1 could be a completely unusable value for some networks while acceptable for some other)

Considered change

  • For backward compatibility, keeps confirmation_count, this value would be used as a secure fallback on all networks (so would remain the same as currently)
  • Determine and implement other fields

Example of other fields

  • safe_inbound_confirmation_count
  • fast_inbound_confirmation_count
  • safe_outbound_confirmation_count
  • fast_outbound_confirmation_count
@lumtis
Copy link
Member Author

lumtis commented Feb 3, 2025

TODO: add a migration script setting for all chains the same values as the current confirmation_count

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant