Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ZETA withdraw at the protocol level if ZETA not enabled #2648

Closed
Tracked by #2745
lumtis opened this issue Aug 7, 2024 · 2 comments
Closed
Tracked by #2745

Prevent ZETA withdraw at the protocol level if ZETA not enabled #2648

lumtis opened this issue Aug 7, 2024 · 2 comments

Comments

@lumtis
Copy link
Member

lumtis commented Aug 7, 2024

For new added supported networks, we don't enabled ZETA withdraws.

However, a CCTX can still be initiated by interacting with the connector. This create the CCTX that gets reverted or aborted/
This will lead to:

  • UX confusion as there are no information feature is disabled
  • fee payment for the CCTX before reverting
  • worst case scenario: aborted because message passing was used an no hook for the revert

We need to prevent at the protocol level from initiating a CCTX if ZETA is not support and gives a message that it is not supported.

One solution can be to use the ChainParams: ZetaTokenAddress or ConnectorAddress not set mean it is disabled.

@lumtis lumtis added this to the August Release milestone Aug 7, 2024
@lumtis
Copy link
Member Author

lumtis commented Aug 7, 2024

Adding for August release as it can be part of the smart contract environment migration. Need to assess complexity.

@lumtis
Copy link
Member Author

lumtis commented Nov 4, 2024

ZETA has been disabled in the gateway contract

@lumtis lumtis closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant