Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a histogram for zetaclient keysigning #2564

Closed
gartnera opened this issue Jul 25, 2024 · 0 comments · Fixed by #2567
Closed

Use a histogram for zetaclient keysigning #2564

gartnera opened this issue Jul 25, 2024 · 0 comments · Fixed by #2567
Assignees
@gartnera
Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations

Comments

@gartnera
Copy link
Member

Tss_Tss_keysign_time comes from https://github.com/zeta-chain/go-tss, but it is updated every time a keysign completes. Since we do several concurrently, it will overwrite itself every time it completes.

What we actually should do is make our own histogram so each keysign is recorded.
@gartnera gartnera added the feature:idea An early idea for a feature. Used as reference to follow new feature integrations label Jul 25, 2024
@gartnera gartnera self-assigned this Jul 25, 2024
@gartnera gartnera mentioned this issue Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gartnera gartnera

Labels
feature:idea An early idea for a feature. Used as reference to follow new feature integrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(zetaclient): add TSS sign latency histogram zeta-chain/node
1 participant
@gartnera