Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine database operations in base observer #2503

Open
Tracked by #1611
swift1337 opened this issue Jul 18, 2024 · 2 comments
Open
Tracked by #1611

Refine database operations in base observer #2503

swift1337 opened this issue Jul 18, 2024 · 2 comments
Labels
code-quality Code quality improvement enhancement New feature or request zetaclient Issues related to ZetaClient

Comments

@swift1337
Copy link
Contributor

swift1337 commented Jul 18, 2024 •
edited
Loading

Describe the Issue
Simplify base observer's methods: ReadLastBlockScannedFromDB, SaveLastBlockScanned, WithLastBlockScanned, WriteLastBlockScannedToDB

Expected Outcome
Observers codebase should become way cleaner and simpler
@swift1337 swift1337 added enhancement New feature or request zetaclient Issues related to ZetaClient code-quality Code quality improvement labels Jul 18, 2024
@lumtis lumtis mentioned this issue Jul 18, 2024
Closed
@lumtis
Copy link
Member

lumtis commented Jul 18, 2024

Added it to #1611

We can use this EPIC to track all issues for improving ZetaClient codebase quality.

In some point we can consider closing the epic and just using triaging with code-qualidty label but for now it allows to have a high-level view on the consideration for most important code quality improvement

@swift1337 swift1337 changed the title Improve observers codebase Refine database operations in base observer Dec 10, 2024
@swift1337
Copy link
Contributor Author

swift1337 commented Dec 10, 2024 •
edited
Loading

I narrowed the scope to avoid conflicts with #2381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Code quality improvement enhancement New feature or request zetaclient Issues related to ZetaClient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lumtis @swift1337