Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCTXs are aborted if an omnichain smart contract call fails at the post tx phase #2037

Closed
Tracked by #2745
lumtis opened this issue Apr 17, 2024 · 1 comment
Closed
Tracked by #2745
Labels
bug Something isn't working m:crosschain m:fungible

Comments

@lumtis
Copy link
Member

lumtis commented Apr 17, 2024

Describe the Issue
The cctx is reverted if the smart contract call revert but abort if parsing the events emitted by this smart contract fail (in the post tx hook).
Example: https://zetachain.blockpi.network/lcd/v1/public/zeta-chain/crosschain/in_tx_hash_to_cctx_[…]f3612016d05f11ac995eddce5de8f8b0d37dfaf678d9b19e468e1c39

The emissions of these events is controlled by the end-user, therefore aborting the CCTX under these conditions decrease the user friendliness.

Solution
We need to investigate the current workflow causing the abort and consider changing the logic to use revert in case of post tx hook fail

@lumtis lumtis added bug Something isn't working m:crosschain m:fungible labels Apr 17, 2024
@lumtis lumtis added this to the v17 milestone Apr 18, 2024
@lumtis lumtis mentioned this issue Apr 19, 2024
10 tasks
@lumtis lumtis removed this from the v17 milestone Jun 3, 2024
@lumtis lumtis added this to the August milestone Jul 18, 2024
@lumtis lumtis removed this from the August Release milestone Aug 19, 2024
@lumtis
Copy link
Member Author

lumtis commented Jan 7, 2025

Fixed by #3321

@lumtis lumtis closed this as completed Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working m:crosschain m:fungible
Projects
None yet
Development

No branches or pull requests

1 participant