Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a common base for chain clients (BitcoinClient and EVMChainClient currently) #2022

Closed
Tracked by #1611
lumtis opened this issue Apr 15, 2024 · 0 comments · Fixed by #2359
Closed
Tracked by #1611
Assignees
Labels
zetaclient Issues related to ZetaClient

Comments

@lumtis
Copy link
Member

lumtis commented Apr 15, 2024

Describe the Issue

EVMChainClient and BitcoinClient has a lot in common aside from the logic to actually observe transactions

We should consider grouping the common logic under a chain base, this would also be reused for future chains

This eventually can be defined in the chain_client package from #2020 by create a ChainClientBase

Some of the tasks:

  • Group common logic in in NewBitcoinClient and NewEVMChainClient
  • A function initializing logger, core_context, etc..

Bonus: renaming client into observer, since this is the component observing external chain transaction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
zetaclient Issues related to ZetaClient
Projects
None yet
2 participants