Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all outTx mentions as outbound and all inTx as inbound #2011

Closed
lumtis opened this issue Apr 11, 2024 · 2 comments · Fixed by #2118
Closed

Rename all outTx mentions as outbound and all inTx as inbound #2011

lumtis opened this issue Apr 11, 2024 · 2 comments · Fixed by #2118
Assignees
Labels
code-quality Code quality improvement

Comments

@lumtis
Copy link
Member

lumtis commented Apr 11, 2024

Describe the Issue
There are place were we use both of these terms for the same representation. We should do some renaming for consistency.

I think outbound and inbound are nicer names

@lumtis lumtis added the code-quality Code quality improvement label Apr 11, 2024
@ws4charlie
Copy link
Contributor

Just put a bit more background here. The inTx and outTx are abbreviations for inbound transaction and outbound transaction. Zetaclient also uses in logging, for instance confirmed outtx hash: 0xd2eba..... for chain 1 nonce 9718. If there are places to indicate inbound/outbound transaction, the intx/outtx will probably still one of good choices.

@lumtis
Copy link
Member Author

lumtis commented Apr 12, 2024

Just put a bit more background here. The inTx and outTx are abbreviations for inbound transaction and outbound transaction. Zetaclient also uses in logging, for instance confirmed outtx hash: 0xd2eba..... for chain 1 nonce 9718. If there are places to indicate inbound/outbound transaction, the intx/outtx will probably still one of good choices.

The is that inbound is a tx by definition, so it simplifies and remove ambiguity these are two different things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code quality improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants