Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout flags for the zetae2e run command #1981

Closed
Tracked by #1720
lumtis opened this issue Apr 3, 2024 · 0 comments
Closed
Tracked by #1720

Add timeout flags for the zetae2e run command #1981

lumtis opened this issue Apr 3, 2024 · 0 comments
Labels
E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Apr 3, 2024

Currently the run command set 60 minutes for the timeout used in E2E tests

testRunner.CctxTimeout = 60 * time.Minute
testRunner.ReceiptTimeout = 60 * time.Minute

cctx -> timeout for the mining of a cctx
receipt -> timeout for getting the receipt on an EVM network

This values are too high if we test the command on localnet or testnet (or a fast network on mainnet in general). We should consider flags to set timeout and eventually reduce the default 60min one

I think minutes are the best unit of measure for this timeout

zetae2e run ... --timeout-cctx 5 --timeout-receipt 3

Use 5 and 3 minutes for the values

Alternative

Set the values in the config since determining these values will generally depends on the network we use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E E2E tests related
Projects
None yet
Development

No branches or pull requests

1 participant