Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace common package with pkg #1905

Closed
lumtis opened this issue Mar 15, 2024 · 0 comments · Fixed by #1936
Closed

Replace common package with pkg #1905

lumtis opened this issue Mar 15, 2024 · 0 comments · Fixed by #1936
Assignees
Labels
codebase-quality Quality of the codebase

Comments

@lumtis
Copy link
Member

lumtis commented Mar 15, 2024

Describe the Issue
common package is a bit too general as a name and group too many different thing under the same namespace. Also it is generally not recommended to use common as a name

Expected Outcome
Idea of the issue is to group the different logic in common into reusable and scoped packages under pkg

pkg/chains
pkg/address
pkg/proofs

as conventional in GO https://pkg.go.dev/github.com/geektime007/mgmt/pkg#section-readme

@lumtis lumtis added the codebase-quality Quality of the codebase label Mar 15, 2024
@skosito skosito self-assigned this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codebase-quality Quality of the codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants