Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a high level VoteOnBallot function #1806

Closed
Tracked by #1711
lumtis opened this issue Feb 26, 2024 · 0 comments · Fixed by #2464
Closed
Tracked by #1711

Create a high level VoteOnBallot function #1806

lumtis opened this issue Feb 26, 2024 · 0 comments · Fixed by #2464
Assignees
Labels
code-quality Code quality improvement m:observer
Milestone

Comments

@lumtis
Copy link
Member

lumtis commented Feb 26, 2024

Describe the Issue
Context: https://github.com/zeta-chain/node/pull/1511/files/76e2198cc6aa3ed3dfbfd0992456bcebda74e2d3#r1500968292 and https://github.com/zeta-chain/node/pull/1511/files/76e2198cc6aa3ed3dfbfd0992456bcebda74e2d3#r1500963921

We have several message implying voting on Ballot:

  • inbound vote
  • outbound vote
  • tss vote
  • blame vote
  • block header vote

Each implement common logic like fetching the ballot, adding vote, checking if finalized.

I would make more sense to create a high level function that can factorize the common logic.

Expected Outcome

  • Implement a function like VoteOnBallot in the observer module
  • Add unit test to this function
  • Change logic of the messages listed above to include this function
@lumtis lumtis added this to the v17 milestone Mar 25, 2024
@lumtis lumtis added the code-quality Code quality improvement label May 2, 2024
@lumtis lumtis modified the milestones: v17, v18 May 2, 2024
@fbac fbac self-assigned this Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality Code quality improvement m:observer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants