Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all mention of USDT into ERC20 in E2E tests #1623

Closed
Tracked by #1720
lumtis opened this issue Jan 23, 2024 · 0 comments · Fixed by #1851
Closed
Tracked by #1720

Rename all mention of USDT into ERC20 in E2E tests #1623

lumtis opened this issue Jan 23, 2024 · 0 comments · Fixed by #1851
Assignees
@skosito
Labels
codebase-quality Quality of the codebase E2E E2E tests related

Comments

@lumtis
Copy link
Member

lumtis commented Jan 23, 2024

USDT is currently used as an example of ERC20 in local E2E tests. However, we might want to test a different type of ERC20 during E2E testing on real networks.
We should rename every mention of USDT into ERC20 in the E2E tests, and also change the name in the config.
@lumtis lumtis added the E2E E2E tests related label Jan 23, 2024
@lumtis lumtis added the codebase-quality Quality of the codebase label Feb 6, 2024
@lumtis lumtis mentioned this issue Feb 6, 2024
Open
@skosito skosito mentioned this issue Mar 6, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skosito skosito

Labels
codebase-quality Quality of the codebase E2E E2E tests related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: remove usdt mentions from e2e tests zeta-chain/node
2 participants
@lumtis @skosito